From: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, david-b@pacbell.net,
ralf@linux-mips.org, linux-mips@linux-mips.org,
g.liakhovetski@pengutronix.de, greg@kroah.com,
kay.sievers@vrfy.org, rmk+kernel@arm.linux.org.uk
Subject: Re: [PATCH] gpio_free might sleep, mips architecture
Date: Thu, 18 Sep 2008 11:32:42 +0200 [thread overview]
Message-ID: <20080918093242.GA7627@informatik.uni-freiburg.de> (raw)
In-Reply-To: <20080917143955.2d3727e5.akpm@linux-foundation.org>
Hello,
Andrew Morton wrote:
> > diff --git a/include/asm-mips/mach-rc32434/gpio.h b/include/asm-mips/mach-rc32434/gpio.h
> > index f946f5f..9b4722e 100644
> > --- a/include/asm-mips/mach-rc32434/gpio.h
> > +++ b/include/asm-mips/mach-rc32434/gpio.h
> > @@ -13,6 +13,7 @@
> > #ifndef _RC32434_GPIO_H_
> > #define _RC32434_GPIO_H_
> >
> > +#include <linux/kernel.h>
> > #include <linux/types.h>
> >
> > struct rb532_gpio_reg {
> > @@ -88,6 +89,7 @@ static inline int gpio_request(unsigned gpio, const char *label)
> > static inline void gpio_free(unsigned gpio)
> > {
> > /* Not yet implemented */
> > + might_sleep();
> > }
> >
>
> There is no gpio_free() in linux-next's include/asm-mips/mach-rc32434/gpio.h
This is OK. This machine type is converted to GPIO lib in linus-next.
So just drop the two hunks for this file. (Note, you only dropped the
addition of might_sleep, but then including linux/kernel.h isn't needed
either.)
Best regards and thanks
Uwe
--
Uwe Kleine-König
exit vi, lesson II:
: w q ! <CR>
NB: write the current file
next prev parent reply other threads:[~2008-09-18 9:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200807230916.48056.david-b@pacbell.net>
2008-07-24 7:28 ` [PATCH] add might_sleep() to all implementations of gpio_free Uwe Kleine-König
2008-07-24 7:33 ` Uwe Kleine-König
2008-09-15 20:02 ` [PATCH] gpio_free might sleep, generic part Uwe Kleine-König
2008-09-15 20:02 ` [PATCH] gpio_free might sleep, arm architecture Uwe Kleine-König
2008-09-15 20:02 ` [PATCH] gpio_free might sleep, mips architecture Uwe Kleine-König
2008-09-15 20:02 ` [PATCH] gpio_free might sleep, blackfin architecture Uwe Kleine-König
2008-09-15 20:02 ` [PATCH] gpio_free might sleep, x86 architecture Uwe Kleine-König
2008-09-17 12:59 ` Ingo Molnar
2008-09-16 2:16 ` [PATCH] gpio_free might sleep, blackfin architecture Bryan Wu
2008-09-17 19:30 ` Uwe Kleine-König
2008-09-17 21:39 ` [PATCH] gpio_free might sleep, mips architecture Andrew Morton
2008-09-18 9:32 ` Uwe Kleine-König [this message]
2008-09-18 13:59 ` Ralf Baechle
2008-09-15 21:21 ` [PATCH] gpio_free might sleep, arm architecture David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918093242.GA7627@informatik.uni-freiburg.de \
--to=ukleinek@informatik.uni-freiburg.de \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=g.liakhovetski@pengutronix.de \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®