mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Michael Buesch <mb@bu3sch.de>, Ivo van Doorn <IvDoorn@gmail.com>
Subject: Re: [PATCH] rfkill: update LEDs for all state changes
Date: Thu, 18 Sep 2008 10:18:24 -0300	[thread overview]
Message-ID: <20080918131824.GD1583@khazad-dum.debian.net> (raw)
In-Reply-To: <48D25311.1010805@lwfinger.net>

On Thu, 18 Sep 2008, Larry Finger wrote:
> Henrique de Moraes Holschuh wrote:
> > Curious.  My patch to rfkill WAS tested, and it DOES fix the same issue you
> > reported (hardware state changes to HARD_BLOCKED do not update the LEDs) in
> > thinkpad-acpi.  It is also an "obviously correct" patch.
> > 
> > What this probably means is that b43 would need a little more rfkill surgery
> > than what Matthew's patch already did.  I will look over Matthew's patch,
> > but my guess is that Michael's comments about the need to add some extra
> > code to b43 to actually synthesize the rfkill state from the separate HW and
> > SW rfkill input lines are a strong hint of where the problem might be.
> 
> You must have missed my mail that shows the corrected patch for b43.
> See http://marc.info/?l=linux-wireless&m=122171448920267&w=2.

Indeed I have.  I will read it now and comment on it.

Thanks for the heads' up :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

  reply	other threads:[~2008-09-18 13:18 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-16 14:18 Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Larry Finger
2008-09-16 15:42 ` Michael Buesch
2008-09-16 17:08   ` Larry Finger
2008-09-16 19:18     ` Carlos Corbacho
2008-09-16 19:25       ` Michael Buesch
2008-09-16 22:37         ` Henrique de Moraes Holschuh
2008-09-17 14:26           ` Michael Buesch
2008-09-17 14:29             ` John W. Linville
2008-09-17 14:33               ` Michael Buesch
2008-09-16 19:30       ` Larry Finger
2008-09-16 23:32         ` Matthew Garrett
2008-09-17  2:33           ` Henrique de Moraes Holschuh
2008-09-17  2:52             ` Larry Finger
2008-09-17 13:23               ` John W. Linville
2008-09-17 20:07             ` [PATCH] rfkill: update LEDs for all state changes Henrique de Moraes Holschuh
2008-09-17 20:55               ` Larry Finger
2008-09-18 12:43                 ` Henrique de Moraes Holschuh
2008-09-18 13:09                   ` Larry Finger
2008-09-18 13:18                     ` Henrique de Moraes Holschuh [this message]
2008-09-18 12:49               ` Ivo van Doorn
2008-09-17 14:22           ` Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Michael Buesch
2008-09-17 14:50             ` Henrique de Moraes Holschuh
2008-09-17 15:28               ` Larry Finger
2008-09-17 15:36                 ` Henrique de Moraes Holschuh
2008-09-17 15:47                   ` Larry Finger
2008-09-16 19:51     ` Matthew Garrett
2008-09-16 20:34       ` Larry Finger
2008-09-16 21:09         ` Matthew Garrett
2008-09-17 14:19           ` Michael Buesch
2008-09-17 15:18             ` Henrique de Moraes Holschuh
2008-09-17 15:59               ` Michael Buesch
2008-09-16 20:44       ` Carlos Corbacho
2008-09-16 21:07         ` Larry Finger
2008-09-16 22:40           ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080918131824.GD1583@khazad-dum.debian.net \
    --to=hmh@hmh.eng.br \
    --cc=IvDoorn@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®