From: Michael E Brown <Michael_E_Brown@dell.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Add Dell laptop driver
Date: Thu, 18 Sep 2008 15:22:57 -0500 [thread overview]
Message-ID: <20080918202257.GJ14180@duo.us.dell.com> (raw)
In-Reply-To: <20080816202452.GA3331@srcf.ucam.org>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Sat, Aug 16, 2008 at 09:24:52PM +0100, Matthew Garrett wrote:
> This driver adds backlight and rfkill support for Dell laptops. It uses
> the DCDBAS driver to trigger the system management calls required for
> this, and parses the DMI tables itself in order to find the appropriate
> tokens. In future it should be possible to add LED control, but I don't
> have any appropriate machines right now for testing.
Sorry, I'm *way* late on giving feedback for this (thanks for the cc). Aside
from the other code review comments, I agree with the approach and am glad
somebody finally took the time to write this correctly.
The i8k driver incorrectly hardcodes magic port io data/address. Can somebody
fix i8k to use the code in this module to do it correctly?
--
Michael Brown
libsmbios maintainer
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2008-09-18 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 20:24 Matthew Garrett
2008-08-16 20:26 ` [PATCH 1/2] Export SMI call functionality from dcdbas driver Matthew Garrett
2008-08-16 20:30 ` [PATCH 2/2] Add Dell laptop driver Matthew Garrett
2008-08-16 20:47 ` Arjan van de Ven
2008-08-16 20:51 ` Matthew Garrett
2008-08-20 6:46 ` Andrew Morton
2008-08-20 10:21 ` Matthew Garrett
2008-09-18 20:22 ` Michael E Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918202257.GJ14180@duo.us.dell.com \
--to=michael_e_brown@dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®