From: Arjan van de Ven <arjan@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, Yinghai Lu <Yinghai.Lu@Sun.COM>
Subject: sparse_irq: userspace ABI breakage in -tip tree
Date: Fri, 19 Sep 2008 15:53:21 -0700 [thread overview]
Message-ID: <20080919155321.1181638a@infradead.org> (raw)
commit 70426a06a58561c401e64c5767d71a011d4b978b
Author: Yinghai Lu <yhlu.kernel@gmail.com>
Date: Tue Aug 19 20:50:27 2008 -0700
x86: make 32 bit to use sparse_irq
@@ -285,7 +303,7 @@ int show_interrupts(struct seq_file *p, void *v)
action = desc->action;
if (!action && !any_count)
goto skip;
- seq_printf(p, "%3d: ",i);
+ seq_printf(p, "%#x: ",i);
#ifndef CONFIG_SMP
seq_printf(p, "%10u ", kstat_irqs(i));
#else
this is a userspace ABI breakage; you're changing /proc/interrupts from
decimal to hex! This file is used by both humans and computer programs,
and the humans will get confused, but the computer programs will break.
Not a good idea to put into mainline.
(I'm not so convinced of sparse_irq as a whole to be honest, but that's
a different story)
next reply other threads:[~2008-09-19 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 22:53 Arjan van de Ven [this message]
2008-09-20 0:10 ` Yinghai Lu
2008-09-20 0:44 ` Arjan van de Ven
2008-09-20 0:47 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080919155321.1181638a@infradead.org \
--to=arjan@infradead.org \
--cc=Yinghai.Lu@Sun.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®