mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Pirko <jpirko@redhat.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] audit: removed bogus newline
Date: Fri, 19 Sep 2008 16:51:46 +0200	[thread overview]
Message-ID: <20080919165146.0aa2ab80@psychotron.englab.brq.redhat.com> (raw)

Hi.

PATH records, as output by the kernel, contain a newline after the
flags fields, which is in the middle of the record. EXECVE records
contain a newline after every argument. auditd seems to hide this,
but they're there nevertheless. If you're not using auditd, you
need to work round them.

What do you think about it?

Jirka


Signed-off-by: Jiri Pirko <jpirko@redhat.com>

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 59cedfb..bf10cb0 100644
--- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -1119,7 +1119,7 @@ static int audit_log_single_execve_arg(struct audit_context *context,
 			audit_log_n_hex(*ab, buf, to_send);
 		else
 			audit_log_format(*ab, "\"%s\"", buf);
-		audit_log_format(*ab, "\n");
+		audit_log_format(*ab, " ");
 
 		p += to_send;
 		len_left -= to_send;

             reply	other threads:[~2008-09-19 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-19 14:51 Jiri Pirko [this message]
2008-09-19 21:38 ` Andrew Morton
2008-09-20 15:01   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080919165146.0aa2ab80@psychotron.englab.brq.redhat.com \
    --to=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®