mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Frans Pop <elendil@planet.nl>
Cc: Rene Herman <rene.herman@keyaccess.nl>,
	linux-kernel@vger.kernel.org, Rene Herman <rene.herman@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [bisected][resend] pnp: Huge number of "io resource overlap" messages
Date: Sat, 20 Sep 2008 17:56:24 -0600	[thread overview]
Message-ID: <200809201756.25157.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <200809210149.07755.elendil@planet.nl>

On Saturday 20 September 2008 05:49:05 pm Frans Pop wrote:
> On Thursday 18 September 2008, Bjorn Helgaas wrote:
> > On Tuesday 09 September 2008 12:31:09 pm Rene Herman wrote:
> > > On 09-09-08 19:40, Bjorn Helgaas wrote:
> > > > If the PCI device isn't fully initialized, it doesn't seem right to
> > > > check it for resource conflicts.  But I don't know how to tell
> > > > that.
> > >
> > > His pci_resource_start() values are 0. How about just checking for
> > > that?
> >
> > Frans, can you test Rene's patch?  I think it will solve the problem
> > you're seeing, and if so, we should put it in for 2.6.27.  But I'd like
> > to have your "Tested-by" first.
> 
> Tested against current git (v2.6.27-rc6-158-g9824b8f) and looks good.
> Attached the patch with Rene's Signed-off and my Tested-by for 
> convenience.
> 
> I had not tested earlier as you said you wanted to better understand the 
> cause first. Did you get anything more about why things happen as they do 
> from the info I sent?

Thanks for testing this.

We're looking at some other issues in the same area, or at least,
where the fix might be in the same area:
  http://bugzilla.kernel.org/show_bug.cgi?id=10231
  http://bugzilla.kernel.org/show_bug.cgi?id=9904

I am still not 100% comfortable with this because I think we really
want to know whether the BAR value is zero, not whether the CPU
address is zero, and pci_resource_start() gives us the CPU address.

Bus and CPU addresses are currently identical on x86, but I expect
that will change someday.  They're already different on ia64 and
some other architectures.

Bottom line, I think we should tweak the patch to check the BAR
address before we put it in.

Bjorn


  reply	other threads:[~2008-09-20 23:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 10:50 Frans Pop
2008-09-09 11:22 ` Rene Herman
2008-09-09 15:30 ` Bjorn Helgaas
2008-09-09 16:26   ` Frans Pop
2008-09-09 17:40     ` Bjorn Helgaas
2008-09-09 18:31       ` Rene Herman
2008-09-18  5:10         ` Bjorn Helgaas
2008-09-20 23:49           ` Frans Pop
2008-09-20 23:56             ` Bjorn Helgaas [this message]
2008-09-26 21:40               ` [Bug #11550] " Bjorn Helgaas
2008-09-27 15:16                 ` Frans Pop
2008-09-27 20:53                 ` Ingo Molnar
2009-03-04 20:17                 ` Frans Pop
2009-03-04 21:53                   ` Bjorn Helgaas
2009-03-20  2:07                     ` Jesse Barnes
2009-03-23 15:46                       ` Bjorn Helgaas
2008-09-10  7:39       ` [bisected][resend] " Frans Pop
2008-09-10 21:34         ` Bjorn Helgaas
2008-09-11 16:58           ` Frans Pop
2008-11-07  9:51       ` Frans Pop
2008-11-07 10:00         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809201756.25157.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=elendil@planet.nl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rene.herman@gmail.com \
    --cc=rene.herman@keyaccess.nl \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®