From: Ingo Molnar <mingo@elte.hu>
To: Russ Anderson <rja@sgi.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH 4/4] x86: Add sysfs entries for UV
Date: Tue, 23 Sep 2008 13:03:16 +0200 [thread overview]
Message-ID: <20080923110316.GB29021@elte.hu> (raw)
In-Reply-To: <20080922211051.GG222374@sgi.com>
* Russ Anderson <rja@sgi.com> wrote:
> +struct kobject *sgi_uv_kobj;
should be static?
> +static int __init sgi_uv_sysfs_init(void)
> +{
> + if (!sgi_uv_kobj)
> + sgi_uv_kobj = kobject_create_and_add("sgi_uv", firmware_kobj);
> + if (!sgi_uv_kobj) {
> + printk(KERN_WARNING "kobject_create_and_add sgi_uv failed \n");
> + return -EINVAL;
> + }
> +
> + sysfs_create_file(sgi_uv_kobj, &partition_id_attr.attr);
> + sysfs_create_file(sgi_uv_kobj, &coherence_id_attr.attr);
missing checks for failure?
Ingo
next prev parent reply other threads:[~2008-09-23 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-22 21:10 Russ Anderson
2008-09-23 11:03 ` Ingo Molnar [this message]
2008-09-23 18:11 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2008-08-22 21:55 Russ Anderson
2008-08-23 2:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923110316.GB29021@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®