From: Arjan van de Ven <arjan@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Arjan van de Ven <arjan@infradead.org>,
mingo@elte.hu, Hugh Dickins <hugh@veritas.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: [PATCH 3/3] corruption check: fix various checkpatch warnings
Date: Tue, 23 Sep 2008 21:54:46 -0700 [thread overview]
Message-ID: <20080923215446.21cd678f@infradead.org> (raw)
In-Reply-To: <20080923215335.05678239@infradead.org>
>From 9e49c38637f335d5c91a0f1c4deea7ce2c20aa34 Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <arjan@linux.intel.com>
Date: Tue, 23 Sep 2008 11:09:10 -0700
Subject: [PATCH] corruption check: fix various checkpatch warnings
Cleanups as suggested by Randy / checkpatch.pl
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
arch/x86/kernel/check.c | 8 ++++----
include/linux/kernel.h | 5 -----
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kernel/check.c b/arch/x86/kernel/check.c
index b22733f..c59bfe6 100644
--- a/arch/x86/kernel/check.c
+++ b/arch/x86/kernel/check.c
@@ -80,7 +80,7 @@ void __init setup_bios_corruption_check(void)
corruption_check_size = round_up(corruption_check_size, PAGE_SIZE);
- while(addr < corruption_check_size && num_scan_areas < MAX_SCAN_AREAS) {
+ while (addr < corruption_check_size && num_scan_areas < MAX_SCAN_AREAS) {
u64 size;
addr = find_e820_area_size(addr, &size, PAGE_SIZE);
@@ -119,11 +119,11 @@ void check_for_bios_corruption(void)
if (!memory_corruption_check)
return;
- for(i = 0; i < num_scan_areas; i++) {
+ for (i = 0; i < num_scan_areas; i++) {
unsigned long *addr = __va(scan_areas[i].addr);
unsigned long size = scan_areas[i].size;
- for(; size; addr++, size -= sizeof(unsigned long)) {
+ for (; size; addr++, size -= sizeof(unsigned long)) {
if (!*addr)
continue;
printk(KERN_ERR "Corrupted low memory at %p (%lx phys) = %08lx\n",
@@ -150,7 +150,7 @@ static void periodic_check_for_corruption(unsigned long data)
-int start_periodic_check_for_corruption(void)
+static int start_periodic_check_for_corruption(void)
{
if (!memory_corruption_check || corruption_check_period == 0)
return 0;
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 01085d2..b39c7ef 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -260,15 +260,10 @@ extern int root_mountflags;
* able to scatter it around anywhere in the kernel.
*/
void check_for_bios_corruption(void);
-int start_periodic_check_for_corruption(void);
#else
static inline void check_for_bios_corruption(void)
{
}
-
-static inline void start_periodic_check_for_corruption(void)
-{
-}
#endif
/* Values used for system_state */
--
1.5.5.1
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-09-24 4:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 4:53 [PATCH 1/3] corruption check: move the corruption checks into their own file Arjan van de Ven
2008-09-24 4:54 ` [PATCH 2/3] corruption check: run the corruption checks from a work queue Arjan van de Ven
2008-09-24 5:54 ` Andrew Morton
2008-09-24 4:54 ` Arjan van de Ven [this message]
2008-09-24 5:53 ` [PATCH 1/3] corruption check: move the corruption checks into their own file Andrew Morton
2008-09-24 17:16 ` Arjan van de Ven
2008-09-24 19:36 ` Randy Dunlap
2008-09-25 10:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080923215446.21cd678f@infradead.org \
--to=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®