From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, andi@firstfloor.org,
joerg.roedel@amd.com, fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH 3/3] x86: restore old GART alloc_coherent behavior
Date: Wed, 24 Sep 2008 14:06:44 +0100 [thread overview]
Message-ID: <20080924140644.569cdd1d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1222256917-14321-4-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Wed, 24 Sep 2008 20:48:37 +0900
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> Currently, GART alloc_coherent tries to allocate pages with GFP_DMA32
> for a device having dma_masks > 24bit < 32bits. If GART gets an
> address that a device can't access to, GART try to map the address to
> a virtual I/O address that the device can access to.
>
> But Andi pointed out, "The GART is somewhere in the 4GB range so you
> cannot use it to map anything < 4GB. Also GART is pretty small."
>
> http://lkml.org/lkml/2008/9/12/43
>
> That is, it's possible that GART doesn't have virtual I/O address
> space that a device can access to. The above behavior doesn't work for
> a device having dma_masks > 24bit < 32bits.
>
> This patch restores old GART alloc_coherent behavior (before the
> alloc_coherent rewrite).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Alan Cox <alan@redhat.com>
This is indeed a specific problem found with things like older AACRAID
where control blocks must be below 31bits and the GART is above 0x80000000
Alan
next prev parent reply other threads:[~2008-09-24 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 11:48 [PATCH 0/3] x86: restore old GART alloc_coherent FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 1/3] x86: export pci-nommu's alloc_coherent FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 2/3] revert "x86: make GART to respect device's dma_mask about virtual mappings" FUJITA Tomonori
2008-09-24 11:48 ` [PATCH 3/3] x86: restore old GART alloc_coherent behavior FUJITA Tomonori
2008-09-24 12:11 ` Joerg Roedel
2008-09-24 12:43 ` FUJITA Tomonori
2008-09-24 12:57 ` Joerg Roedel
2008-09-24 13:06 ` Alan Cox [this message]
2008-09-24 22:01 ` Andi Kleen
2008-09-24 12:58 ` [PATCH 0/3] x86: restore old GART alloc_coherent Joerg Roedel
2008-09-25 9:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080924140644.569cdd1d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®