From: Yan Li <elliot.li.tech@gmail.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Yan Li <elliot.li.tech@gmail.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
rjmaomao@gmail.com, Yinghai Lu <yhlu.kernel@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
nancydreaming@gmail.com
Subject: Re: [PATCH 2/2] Suppress false "mtrr all empty" warning message when running as VMware guest
Date: Thu, 25 Sep 2008 10:51:02 +0800 [thread overview]
Message-ID: <20080925025102.GI21049@yantp.cn.ibm.com> (raw)
In-Reply-To: <20080924141616.GV24392@amd.com>
On Wed, Sep 24, 2008 at 04:16:16PM +0200, Joerg Roedel wrote:
> A lot of code if #ifdef'ed to vmware. Can you hide this into a header
> file? This way its not very clean code I think.
Hum.. OK, I'm thinking about this.
> Can we move the WARN after the DMI scanning for all cases? This will
> save this #ifdef and is a cleaner approach imho.
Sounds good. Thanks!
--
Li, Yan
next prev parent reply other threads:[~2008-09-25 2:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a120cfa37281607d8dc361deda1a35419accd193.1222258080.git.elliot.li.tech@gmail.com>
2008-09-24 12:24 ` Yan Li
2008-09-24 12:54 ` Laurent Vivier
2008-09-24 13:10 ` Yan Li
2008-09-24 14:16 ` Joerg Roedel
2008-09-25 2:51 ` Yan Li [this message]
2008-09-24 16:39 ` Yinghai Lu
2008-09-25 2:52 ` Yan Li
2008-09-25 14:18 ` Yan Li
2008-09-25 17:13 ` Yinghai Lu
2008-09-26 9:50 ` Yan Li
2008-10-01 20:03 ` Pavel Machek
2008-10-05 12:05 ` Yan Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080925025102.GI21049@yantp.cn.ibm.com \
--to=elliot.li.tech@gmail.com \
--cc=hpa@zytor.com \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nancydreaming@gmail.com \
--cc=rjmaomao@gmail.com \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®