mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: "Yinghai Lu" <yinghai@kernel.org>
Cc: "Jesse Barnes" <jbarnes@virtuousgeek.org>,
	"Len Brown" <lenb@kernel.org>, "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 7/7] x86: print out irq nr for msi/ht -v2
Date: Thu, 25 Sep 2008 11:52:22 -0600	[thread overview]
Message-ID: <200809251152.23021.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <86802c440809251007n71738552n88b8ebfc7ecd017f@mail.gmail.com>

On Thursday 25 September 2008 11:07:17 am Yinghai Lu wrote:
> On Thu, Sep 25, 2008 at 8:00 AM, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
> > On Thursday 25 September 2008 12:13:43 am Yinghai Lu wrote:
> >> v2: fix hpet compiling
> >>
> >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> >> ---
> >>  arch/x86/kernel/hpet.c    |    3 +++
> >>  arch/x86/kernel/io_apic.c |    7 +++++++
> >>  2 files changed, 10 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
> >> index 422c577..686505a 100644
> >> --- a/arch/x86/kernel/hpet.c
> >> +++ b/arch/x86/kernel/hpet.c
> >> @@ -467,6 +467,9 @@ static int hpet_setup_irq(struct hpet_dev *dev)
> >>       irq_set_affinity(dev->irq, cpumask_of_cpu(dev->cpu));
> >>       enable_irq(dev->irq);
> >>
> >> +     printk(KERN_DEBUG "hpet: %s is using irq %#x aka %d for MSI\n",
> >> +                      dev->name, dev->irq, dev->irq);
> >> +
> >
> > Why do we want to print the irq as hex?  Do we do that anywhere else?
> > I think we should pick one format and stick with it, and I think
> > decimal is the logical choice because it's the most common.
> 
> when sparseirq is enabled, irq for msi will be bus_nr/dev/func + 12bits.
> so show it as hex is more straight. but we can not use hex in
> /proc/interrupts --ABI want decimal.
> 
> just try to print out...in log, so user could get some idea that who
> is using it...

I think it'd be better to just print the MSI IRQ number in decimal
using a dev_printk().  Then the connection is obvious and we don't
need to make everything ugly by having IRQs in both decimal and hex.

I know it's a nuisance to make hpet use dev_printk because it's
pretty muddled as far as getting a struct device.  But I'd rather
fix that than add confusion like this.

Bjorn

  reply	other threads:[~2008-09-25 17:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-25  6:13 Yinghai Lu
2008-09-25  8:42 ` Ingo Molnar
2008-09-25  9:12   ` Ingo Molnar
2008-09-25 17:03     ` Yinghai Lu
2008-09-25 17:20     ` Yinghai Lu
2008-09-27 18:44       ` Ingo Molnar
2008-09-25 11:30 ` Rolf Eike Beer
2008-09-25 15:00 ` Bjorn Helgaas
2008-09-25 17:07   ` Yinghai Lu
2008-09-25 17:52     ` Bjorn Helgaas [this message]
2008-09-27 18:53       ` Ingo Molnar
2008-09-27 19:02         ` Cyrill Gorcunov
2008-09-29 17:05           ` Jesse Barnes
2008-09-29 17:29             ` Cyrill Gorcunov
2008-09-29 19:57               ` Grant Grundler
2008-09-30  4:20                 ` Cyrill Gorcunov
2008-09-29 17:45 ` Pallipadi, Venkatesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809251152.23021.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®