From: Pekka Paalanen <pq@iki.fi>
To: "Frédéric Weisbecker" <fweisbec@gmail.com>
Cc: mingo@elte.hu, rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [Path -tip 1/3] Tracing/ftrace: Change the type of the print_line callback
Date: Mon, 29 Sep 2008 18:04:09 +0300 [thread overview]
Message-ID: <20080929180409.68cdf8ba@daedalus.pq.iki.fi> (raw)
In-Reply-To: <c62985530809290211l7df01459lf80456ab98fc6ed0@mail.gmail.com>
On Mon, 29 Sep 2008 11:11:15 +0200
"Frédéric Weisbecker" <fweisbec@gmail.com> wrote:
> 2008/9/28 Pekka Paalanen <pq@iki.fi>:
>
[static int print_trace_line(struct trace_iterator *iter)]
> > Shouldn't the return type be bool?
> > If it's not, reading this function makes me wonder about the conversion
> > from enum to int, i.e. what is the meaning of the int.
>
> Actually it should be enum print_line_t. I forgot to change its type.
> But we need to check its return value as an enum print_line_t.
Is print_line_t necessary? Does it have to return any other information than
"this entry was handled somehow" vs. "this entry must be handled later"?
Currently it's just a flag to say "please flush and retry".
--
Pekka Paalanen
http://www.iki.fi/pq/
next prev parent reply other threads:[~2008-09-29 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 15:25 Frederic Weisbecker
2008-09-28 16:19 ` Pekka Paalanen
2008-09-29 9:11 ` Frédéric Weisbecker
2008-09-29 15:04 ` Pekka Paalanen [this message]
2008-09-29 15:56 ` Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929180409.68cdf8ba@daedalus.pq.iki.fi \
--to=pq@iki.fi \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®