From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr) function
Date: Mon, 29 Sep 2008 18:45:19 +0100 [thread overview]
Message-ID: <20080929184519.11d08dc4@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200809291020.12942.jbarnes@virtuousgeek.org>
> > This is the same like pci_iomap(pdev, number, 0), no?
>
> Yeah... Looks like that function isn't that widely used though. Is the maxlen
> param really needed? Looks like the drivers that use it often pass 0 or the
In some cases yes you do need the length.
> BAR length anyway, and Arjan converted existing drivers too, which is where
> the real work is.
He could have converted them to the existing perfectly good API not
invented another one. He still can - I'm sure its a perl one liner to
redo them in terms of pci_iomap()
Alan
next prev parent reply other threads:[~2008-09-29 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 23:36 Arjan van de Ven
2008-09-29 17:02 ` Rolf Eike Beer
2008-09-29 17:20 ` Jesse Barnes
2008-09-29 17:45 ` Alan Cox [this message]
2008-09-29 18:15 ` Arjan van de Ven
2008-09-29 18:26 ` Jesse Barnes
2008-10-02 18:53 ` Jesse Barnes
2008-10-02 19:05 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080929184519.11d08dc4@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=eike-kernel@sf-tec.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®