From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753846AbYI2WCC (ORCPT ); Mon, 29 Sep 2008 18:02:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751602AbYI2WBy (ORCPT ); Mon, 29 Sep 2008 18:01:54 -0400 Received: from one.firstfloor.org ([213.235.205.2]:50829 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbYI2WBx (ORCPT ); Mon, 29 Sep 2008 18:01:53 -0400 Date: Tue, 30 Sep 2008 00:07:17 +0200 From: Andi Kleen To: dean gaudet Cc: Andi Kleen , Pardo , linux-kernel@vger.kernel.org, mbligh@google.com, briangrant@google.com, nil@google.com, jyasskin@google.com Subject: Re: Faster getcpu() and sched_getcpu() Message-ID: <20080929220717.GU25711@one.firstfloor.org> References: <87wsgwp6gh.fsf@basil.nowhere.org> <48E0834D.6010608@google.com> <20080929145408.GQ25711@one.firstfloor.org> <20080929205054.GR25711@one.firstfloor.org> <48E14ECE.6080402@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48E14ECE.6080402@google.com> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 29, 2008 at 02:55:26PM -0700, dean gaudet wrote: > Andi Kleen wrote: > > On Mon, Sep 29, 2008 at 11:01:26AM -0700, Pardo wrote: > > > >>> [Maybe disable frame pointers for vsyscall.c and the vdso?] > >>> > >> IIRC, some vsyscall.c code needs them enabled, so Dean's earlier patch split > >> > > > > I don't think it really needs it. > > > > > >> vsyscall.c, creating a vsyscall_user.c for code which can run without them. > >> Seem reasonable? > >> > > > > Seems unnecessarily complicated. > > > > i disagree that it's complicated to have two files, and disagree that > it's unnecessary to have two files. It's unnecessary to have frame pointer in the kernel functions I meant. I agree with you that disabling redzone is needed for kernel code, but without frame pointers (which are generally a bad idea for performance and should not have been added to the 64bit port ever) redzone is also not particularly expensive and it shouldn't be needed to do anything complicated (like splitting files) just for the few cycles. -Andi -- ak@linux.intel.com