mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [PATCH] Markers : fix reentrancy
Date: Tue, 30 Sep 2008 09:09:23 +0200	[thread overview]
Message-ID: <20080930070923.GB30927@elte.hu> (raw)
In-Reply-To: <20080930054151.GA16961@Krystal>


* Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> Lai Jiangshan <laijs@cn.fujitsu.com> wrote :
> > marker_synchronize_unregister must be called _also_ between unregistration
> > and destruction the data that unregistration-ed probes need to make sure
> > there is no caller executing a probe when it's data is destroyed.
> > 
> 
> Ah, you're right. I looked again through your patch description and I
> think using a :
> 
> 
> if (entry->rcu_pending)
>                 rcu_barrier_sched();
> 
> After each time the markers_mutex is taken would keep the fast batch 
> registration/unregistration and fix the reentrancy problem. The 
> following patch should address the problem.

could you please send a delta patch against tip/master? Lai's patch is 
already applied and is tested. Thanks,

	Ingo

  reply	other threads:[~2008-09-30  7:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-30  5:41 Mathieu Desnoyers
2008-09-30  7:09 ` Ingo Molnar [this message]
2008-09-30 15:52   ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080930070923.GB30927@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®