From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: jens.axboe@oracle.com
Cc: rusty@rustcorp.com.au, oakad@yahoo.com, adrian@mcmen.demon.co.uk,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
j-nomura@ce.jp.nec.com, k-ueda@ct.jp.nec.com
Subject: [PATCH 4/5] block: change elevator to use __blk_end_request()
Date: Wed, 01 Oct 2008 10:13:44 -0400 (EDT) [thread overview]
Message-ID: <20081001.101344.78703914.k-ueda@ct.jp.nec.com> (raw)
In-Reply-To: <20081001.100942.74754500.k-ueda@ct.jp.nec.com>
This patch converts elevator to use __blk_end_request() directly
so that end_{queued|dequeued}_request() can be removed.
Related 'uptodate' arguments is converted to 'error'.
Signed-off-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
---
block/elevator.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Index: linux-2.6-block/block/elevator.c
===================================================================
--- linux-2.6-block.orig/block/elevator.c
+++ linux-2.6-block/block/elevator.c
@@ -754,7 +754,7 @@ struct request *elv_next_request(struct
* not ever see it.
*/
if (blk_empty_barrier(rq)) {
- end_queued_request(rq, 1);
+ __blk_end_request(rq, 0, blk_rq_bytes(rq));
continue;
}
if (!(rq->cmd_flags & REQ_STARTED)) {
@@ -825,7 +825,7 @@ struct request *elv_next_request(struct
break;
} else if (ret == BLKPREP_KILL) {
rq->cmd_flags |= REQ_QUIET;
- end_queued_request(rq, 0);
+ __blk_end_request(rq, -EIO, blk_rq_bytes(rq));
} else {
printk(KERN_ERR "%s: bad return=%d\n", __func__, ret);
break;
@@ -922,7 +922,7 @@ void elv_abort_queue(struct request_queu
rq = list_entry_rq(q->queue_head.next);
rq->cmd_flags |= REQ_QUIET;
blk_add_trace_rq(q, rq, BLK_TA_ABORT);
- end_queued_request(rq, 0);
+ __blk_end_request(rq, -EIO, blk_rq_bytes(rq));
}
}
EXPORT_SYMBOL(elv_abort_queue);
next prev parent reply other threads:[~2008-10-01 14:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 14:09 [PATCH 0/5] block: remove end_{queued|dequeued}_request() Kiyoshi Ueda
2008-10-01 14:11 ` [PATCH 1/5] virtio_blk: change to use __blk_end_request() Kiyoshi Ueda
2008-10-02 4:52 ` Rusty Russell
2008-10-01 14:12 ` [PATCH 2/5] memstick: " Kiyoshi Ueda
2008-10-01 14:13 ` [PATCH 3/5] gdrom: " Kiyoshi Ueda
2008-10-01 14:13 ` Kiyoshi Ueda [this message]
2008-10-01 14:14 ` [PATCH 5/5] block: remove end_{queued|dequeued}_request() Kiyoshi Ueda
2008-10-01 14:19 ` [PATCH 0/5] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001.101344.78703914.k-ueda@ct.jp.nec.com \
--to=k-ueda@ct.jp.nec.com \
--cc=adrian@mcmen.demon.co.uk \
--cc=j-nomura@ce.jp.nec.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oakad@yahoo.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®