From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] x86: remove noop cpus_and() with CPU_MASK_ALL.
Date: Wed, 1 Oct 2008 08:59:52 +1000 [thread overview]
Message-ID: <200810010859.52259.rusty@rustcorp.com.au> (raw)
I'm not sure what this is supposed to do.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 52e0cb95ef98 arch/x86/kernel/io_apic_32.c
--- a/arch/x86/kernel/io_apic_32.c Sat Sep 06 15:18:06 2008 +1000
+++ b/arch/x86/kernel/io_apic_32.c Thu Sep 18 14:30:01 2008 +1000
@@ -346,9 +346,7 @@ static void set_ioapic_affinity_irq(unsi
if (cpus_empty(tmp))
tmp = TARGET_CPUS;
- cpus_and(cpumask, tmp, CPU_MASK_ALL);
-
- apicid_value = cpu_mask_to_apicid(cpumask);
+ apicid_value = cpu_mask_to_apicid(tmp);
/* Prepare to do the io_apic_write */
apicid_value = apicid_value << 24;
spin_lock_irqsave(&ioapic_lock, flags);
@@ -361,7 +359,7 @@ static void set_ioapic_affinity_irq(unsi
break;
entry = irq_2_pin + entry->next;
}
- irq_desc[irq].affinity = cpumask;
+ irq_desc[irq].affinity = tmp;
spin_unlock_irqrestore(&ioapic_lock, flags);
}
@@ -2613,12 +2611,10 @@ static void set_ht_irq_affinity(unsigned
if (cpus_empty(tmp))
tmp = TARGET_CPUS;
- cpus_and(mask, tmp, CPU_MASK_ALL);
-
- dest = cpu_mask_to_apicid(mask);
+ dest = cpu_mask_to_apicid(tmp);
target_ht_irq(irq, dest);
- irq_desc[irq].affinity = mask;
+ irq_desc[irq].affinity = tmp;
}
#endif
next reply other threads:[~2008-09-30 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 22:59 Rusty Russell [this message]
2008-09-30 23:08 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810010859.52259.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®