mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: torvalds@linux-foundation.org, jeff@garzik.org, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	arjan@linux.intel.com
Subject: [PATCH 2.6.27-rc8 0/1] e1000e nvm fix
Date: Wed, 01 Oct 2008 17:18:30 -0700	[thread overview]
Message-ID: <20081002001830.5951.3123.stgit@jbrandeb-bw.jf.intel.com> (raw)

Please apply to 2.6.27

This is related to regression bugzilla:
http://bugzilla.kernel.org/show_bug.cgi?id=11382

This patch is meant to prevent all future corruptions of the
e1000e NVM (non volatile memory) after the driver is loaded.  The
registers stay locked until the machine is power cycled.

This should allow us to move forward with debugging without
allowing any other bad element or the e1000e driver, to write to
the NVM area unexpectedly.

Currently we (Intel Ethernet) are reproducing the issue on
multiple machines in house, we are working on the issue with the
other core Linux teams here at Intel and within the community. No
resolution yet but we are much closer now.

Later we will post patches to help users who have had this
problem restore their eeprom from either a saved image from
ethtool -e or from another identical system.

There is a set of patches to help clean up the driver's use of
the hardware/software semaphore, but those are un-necessary to be
immediately applied once we're locking the NVM.  We will push
those for inclusion within the merge window for 2.6.28.

---

Bruce Allan (1):
      e1000e: write protect ICHx NVM to prevent malicious write/erase


 drivers/net/e1000e/e1000.h   |    2 +
 drivers/net/e1000e/ethtool.c |    3 ++
 drivers/net/e1000e/ich8lan.c |   58 ++++++++++++++++++++++++++++++++++++++++++
 drivers/net/e1000e/netdev.c  |   10 +++++--
 drivers/net/e1000e/param.c   |   30 ++++++++++++++++++++++
 5 files changed, 100 insertions(+), 3 deletions(-)

--
Jesse Brandeburg

             reply	other threads:[~2008-10-02  0:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  0:18 Jesse Brandeburg [this message]
2008-10-02  0:18 ` [PATCH] e1000e: write protect ICHx NVM to prevent malicious write/erase Jesse Brandeburg
2008-10-02  0:42   ` Linus Torvalds
2008-10-02  1:33     ` Arjan van de Ven
2008-10-02  9:05       ` Thomas Gleixner
2008-10-02  9:59   ` Jiri Kosina
2008-10-02 13:02   ` Jiri Kosina
2008-10-02 15:37     ` Brandeburg, Jesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081002001830.5951.3123.stgit@jbrandeb-bw.jf.intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=arjan@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®