From: Borislav Petkov <petkovbb@googlemail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] ide-cd: small drive type print fix
Date: Sat, 4 Oct 2008 10:28:28 +0200 [thread overview]
Message-ID: <20081004082827.GA4160@gollum.tnic> (raw)
In-Reply-To: <200810031918.15455.bzolnier@gmail.com>
On Fri, Oct 03, 2008 at 07:18:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Monday 29 September 2008, Borislav Petkov wrote:
> > Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
>
> applied (though I fail to see "an added value" of this change)
It simply makes the format consistent with the lines below: CD-R/RW - which is
the more common way of enumerating supported media you find in different specs
than DVD-R-RAM, don't you think?
> > ---
> > drivers/ide/ide-cd.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> > index 9ffce7f..e41b94d 100644
> > --- a/drivers/ide/ide-cd.c
> > +++ b/drivers/ide/ide-cd.c
> > @@ -1784,7 +1784,7 @@ static int ide_cdrom_probe_capabilities(ide_drive_t *drive)
> > if ((cdi->mask & CDC_DVD_R) == 0 || (cdi->mask & CDC_DVD_RAM) == 0)
> > printk(KERN_CONT " DVD%s%s",
> > (cdi->mask & CDC_DVD_R) ? "" : "-R",
> > - (cdi->mask & CDC_DVD_RAM) ? "" : "-RAM");
> > + (cdi->mask & CDC_DVD_RAM) ? "" : "/RAM");
> >
> > if ((cdi->mask & CDC_CD_R) == 0 || (cdi->mask & CDC_CD_RW) == 0)
> > printk(KERN_CONT " CD%s%s",
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2008-10-04 8:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 6:29 [PATCH 0/3] ide-cd: debug log enhancements Borislav Petkov
2008-09-29 6:29 ` [PATCH 1/3] " Borislav Petkov
2008-10-03 17:15 ` Bartlomiej Zolnierkiewicz
2008-09-29 6:29 ` [PATCH 2/3] ide-cd: small drive type print fix Borislav Petkov
2008-10-03 17:18 ` Bartlomiej Zolnierkiewicz
2008-10-04 8:28 ` Borislav Petkov [this message]
2008-10-05 15:54 ` Bartlomiej Zolnierkiewicz
2008-09-29 6:29 ` [PATCH 3/3] ide-cd: shorten ide_cd_request_sense_fixup's param list Borislav Petkov
2008-10-03 17:29 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081004082827.GA4160@gollum.tnic \
--to=petkovbb@googlemail.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®