mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: NeilBrown <neilb@suse.de>, Andre Noll <maan@systemlinux.org>,
	Arjan van de Ven <arjan@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [mmotm 02/Oct] fix buid error of autodetect_raid()
Date: Sat, 4 Oct 2008 14:27:39 +0200	[thread overview]
Message-ID: <20081004122739.GB3728@elte.hu> (raw)
In-Reply-To: <20081004211237.CE4D.KOSAKI.MOTOHIRO@jp.fujitsu.com>


* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> Hi Ingo,
> 
> Thank you for very quick responce.
> 
> > > Index: b/init/do_mounts_md.c
> > > ===================================================================
> > > --- a/init/do_mounts_md.c
> > > +++ b/init/do_mounts_md.c
> > > @@ -1,5 +1,6 @@
> > >  
> > >  #include <linux/raid/md.h>
> > > +#include <linux/delay.h>
> > 
> > hm, linux/raid/md.h already has:
> > 
> >   #include <linux/delay.h>
> > 
> > what config triggers this build failure, 
> 
> config attached.
> 
> 
> > and does your version of 
> > include/linux/raid/md.h have a linux/delay.h #include?
> 
> No.
> 
> git-md.patch of current mmotm has following hunk.
> ok, CCing NeilBrown and Andre Noll.
> 
> > diff -puN include/linux/raid/md.h~git-md include/linux/raid/md.h
> > --- a/include/linux/raid/md.h~git-md
> > +++ a/include/linux/raid/md.h
> > @@ -19,27 +19,7 @@
> >  #define _MD_H
> > 
> >  #include <linux/blkdev.h>
> > -#include <linux/major.h>
> > -#include <linux/ioctl.h>
> > -#include <linux/types.h>
> > -#include <linux/bitops.h>
> > -#include <linux/module.h>
> > -#include <linux/hdreg.h>
> > -#include <linux/proc_fs.h>
> >  #include <linux/seq_file.h>
> > -#include <linux/smp_lock.h>
> > -#include <linux/delay.h>
> > -#include <net/checksum.h>
> > -#include <linux/random.h>
> > -#include <linux/kernel_stat.h>
> > -#include <asm/io.h>
> > -#include <linux/completion.h>
> > -#include <linux/mempool.h>
> > -#include <linux/list.h>
> > -#include <linux/reboot.h>
> > -#include <linux/vmalloc.h>
> > -#include <linux/blkpg.h>
> > -#include <linux/bio.h>

ah, that indeed makes sense.

so the build error can not hit the fastboot tree, only if combined with 
the latest raid tree. I've applied your fix to tip/fastboot, thanks!

	Ingo

      reply	other threads:[~2008-10-04 12:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04 10:09 KOSAKI Motohiro
2008-10-04 10:10 ` [mmotm 02/Oct] fix buid error of hid-core KOSAKI Motohiro
2008-10-09  6:45   ` KOSAKI Motohiro
2008-10-09  7:02     ` Andrew Morton
2008-10-09  7:15       ` KOSAKI Motohiro
2008-10-04 10:11 ` [mmotm 02/Oct] fix buid error of md raid KOSAKI Motohiro
2008-10-09  6:47   ` KOSAKI Motohiro
2008-10-04 12:10 ` [mmotm 02/Oct] fix buid error of autodetect_raid() Ingo Molnar
2008-10-04 12:18   ` KOSAKI Motohiro
2008-10-04 12:27     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081004122739.GB3728@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maan@systemlinux.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®