From: "Adam Tlałka" <atlka@pg.gda.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: [PATCH 0/0] SIGWINCH problem with terminal apps
Date: Mon, 6 Oct 2008 20:28:34 +0200 [thread overview]
Message-ID: <20081006202834.5b6c5092@merlin.oi.pg.gda.pl> (raw)
In-Reply-To: <20081006141306.6a1f0a15@lxorguk.ukuu.org.uk>
Hi,
Mon, 6 Oct 2008 14:13:06 +0100 - Alan Cox <alan@lxorguk.ukuu.org.uk>:
> > So as a quick solution I made patches which move mentioned updates
> > before kill_pgrp() calls. As I tested modified kernel there is no
> > observed effect now. So I send patchs.
>
> NAK - this might happen to make the race miss on your box but it's
> not a fix of any kind.
It depends. If mutexes are not working properly only in case of signal
sending then moving variables modification before kill_pgrp() call
could be a quite good enough solution too. Mutexes seems to be faster
and more efficient then semaphores for example.
> The code was never race free, the scheduler change made the problem
> show up more. Later 2.6.27-rc has patches that use the termios lock
> across TIOCG/SWINSZ and deal with the problem properly.
Maybe but what with older versions. Anyway the problem is if mutexes
are usable here or not.
Regards
--
Adam Tlałka
next prev parent reply other threads:[~2008-10-06 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 12:07 Adam Tlałka
2008-10-06 13:13 ` Alan Cox
2008-10-06 18:28 ` Adam Tlałka [this message]
2008-10-06 22:14 ` Alan Cox
2008-10-07 20:28 ` Adam Tlałka
2008-10-10 1:12 ` [PATCH 0/1] SIGWINCH problem with terminal apps still alive Adam Tlałka
2008-10-10 3:32 ` Adam Tlałka
2008-10-10 9:29 ` Alan Cox
2008-10-10 10:35 ` Adam Tlałka
2008-10-10 11:56 ` Adam Tlałka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081006202834.5b6c5092@merlin.oi.pg.gda.pl \
--to=atlka@pg.gda.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®