From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <tj@kernel.org>
Cc: avorontsov@ru.mvista.com, Matt Sealey <matt@genesi-usa.com>,
Jeff Garzik <jgarzik@pobox.com>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, Li Yang <leoli@freescale.com>,
Wang Jian <lark@linux.net.cn>
Subject: Re: [PATCH] pata_of_platform: fix no irq handling
Date: Tue, 7 Oct 2008 10:37:23 +0100 [thread overview]
Message-ID: <20081007103723.0224671e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <48EABBD3.1010401@kernel.org>
> > This was discussed years ago.
> >
> > http://lkml.org/lkml/2005/11/22/159
> > http://lkml.org/lkml/2005/11/22/227
> >
>
> Would this break any existing platforms? If so, can those be fixed
> together or does it become a much bigger problem that way?
Zero means no IRQ. Any platform with bits of code left over exposing IRQ
0 is already not supported by lots of driver code including libata.
As IRQs are unsigned using -1 is asking for trouble
next prev parent reply other threads:[~2008-10-07 9:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 17:26 Anton Vorontsov
2008-10-06 20:41 ` Matt Sealey
2008-10-06 21:32 ` Anton Vorontsov
2008-10-07 1:30 ` Tejun Heo
2008-10-07 9:18 ` Wang Jian
2008-10-07 9:26 ` Anton Vorontsov
2008-10-07 10:04 ` Benjamin Herrenschmidt
2008-10-07 9:37 ` Alan Cox [this message]
2008-10-08 8:40 ` David Woodhouse
2008-10-08 9:00 ` Alan Cox
2008-10-08 9:59 ` Geert Uytterhoeven
2008-10-08 10:27 ` Alan Cox
2008-10-10 17:55 ` Paul Mundt
2008-10-13 6:56 ` Tejun Heo
2008-10-13 13:27 ` Jeff Garzik
2008-10-13 13:53 ` Tejun Heo
2008-10-13 14:02 ` I have returned! Alan Cox
2008-10-16 9:40 ` Jeff Garzik
2008-10-13 14:04 ` [PATCH] fusion: remove dead mpt lan code Alan Cox
2008-10-13 14:05 ` [PATCH] mptsas: remove pointless null check Alan Cox
2008-10-13 14:22 ` James Bottomley
2008-10-13 14:37 ` Alan Cox
2008-10-13 23:27 ` [PATCH] pata_of_platform: fix no irq handling Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081007103723.0224671e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=avorontsov@ru.mvista.com \
--cc=jgarzik@pobox.com \
--cc=lark@linux.net.cn \
--cc=leoli@freescale.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matt@genesi-usa.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®