From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755465AbYJGGvr (ORCPT ); Tue, 7 Oct 2008 02:51:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751728AbYJGGvj (ORCPT ); Tue, 7 Oct 2008 02:51:39 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:59134 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbYJGGvi (ORCPT ); Tue, 7 Oct 2008 02:51:38 -0400 From: KOSAKI Motohiro To: Lai Jiangshan Subject: Re: [PATCH] markers: fix missing modpost entry in Module.markers Cc: kosaki.motohiro@jp.fujitsu.com, Andrew Morton , Greg KH , stable@kernel.org, Linux Kernel Mailing List , Mathieu Desnoyers , Roland McGrath , Wenji Huang , Takashi Nishiie , systemtap@sourceware.org In-Reply-To: <48EB032B.3070200@cn.fujitsu.com> References: <48EB032B.3070200@cn.fujitsu.com> Message-Id: <20081007154401.5A59.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Tue, 7 Oct 2008 15:51:34 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lai Have you seen "Markers in (non-module) kernel code?" thread? I think this patch and that patch treat the same issue. In addition, I think mathieu's patch is better. So, Could I hear your opinition for that? > > commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug. > marker points compiled in vmlinux are missing in Module.markers. > > # cat Module.markers > subsystem_event samples/markers/marker-example integer %d string %s > subsystem_eventb samples/markers/marker-example > > # stap -e 'probe kernel.mark("core_marker_format"){} ' > semantic error: no match while resolving probe point kernel.mark("core_marker_format") > semantic error: no probes found > Pass 2: analysis failed. Try again with more '-v' (verbose) options. > > This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216. > Other parts have fixed duplicate modpost entry bug. > > > Signed-off-by: Lai Jiangshan > --- > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 418cd7d..3509142 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1992,8 +1992,7 @@ static void read_markers(const char *fname) > mod->skip = 1; > } > > - if (!mod->skip) > - add_marker(mod, marker, fmt); > + add_marker(mod, marker, fmt); > } > return; > fail: > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/