From: Alexey Dobriyan <adobriyan@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] h8300: Change unaligned access to use packed struct implementation
Date: Wed, 8 Oct 2008 18:02:14 +0400 [thread overview]
Message-ID: <20081008140214.GC2739@x200.localdomain> (raw)
In-Reply-To: <1223447903.8195.65.camel@brick>
On Tue, Oct 07, 2008 at 11:38:22PM -0700, Harvey Harrison wrote:
> There are only 3 arches that use the memmove-based implementation, there
> doesn't seem to be any obvious reason not to use the struct implementation.
1. Extensive use of "--- " area means changelogs are written badly.
2. Changing one of arch core header we can deduce from patch and this
exactly what subject line says.
3. As such there is absolutely no changelog.
[goes into digging how all this byteorder and endian activity was
started]
> --- a/arch/h8300/include/asm/unaligned.h
> +++ b/arch/h8300/include/asm/unaligned.h
> -#include <linux/unaligned/be_memmove.h>
> +#include <linux/unaligned/be_struct.h>
next prev parent reply other threads:[~2008-10-08 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 6:38 Harvey Harrison
2008-10-08 14:02 ` Alexey Dobriyan [this message]
2008-10-09 1:18 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008140214.GC2739@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®