From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Richard A. Holden III" <aciddeath@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Richard A. Holden III" <aciddeath@gmail.com>
Subject: Re: [PATCH 00/10] ixj: Cleanup dead and duplicate code
Date: Wed, 8 Oct 2008 21:12:32 +0100 [thread overview]
Message-ID: <20081008211232.3a14b4ea@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <cover.1223497216.git.aciddeath@gmail.com>
On Wed, 8 Oct 2008 14:41:35 -0600
"Richard A. Holden III" <aciddeath@gmail.com> wrote:
> Cleanup dead code and duplicate code to start simplifying the ixj
> driver, currently it is around 10000 lines long. This has been built,
> but I don't have the hardware to test, most changes were fairly
> mechanical.
It needs doing but you need to be very very careful and I don't think
this is a good idea to merge untested because if you misprogram the SLIC
you can blow the card up, permanently,magic smoke gone, dead, defunct.
It's one card where we really really don't want to make untested changes.
That said if you've got an old box with an ISA slot somewhere, and a
postal address you can have the old ISA card that Quicknet provided for
testing - contact me off list if you want it.
Alan
next prev parent reply other threads:[~2008-10-08 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 20:41 Richard A. Holden III
2008-10-08 20:12 ` Alan Cox [this message]
2008-10-08 20:41 ` [PATCH 01/10] ixj: Remove code duplication for processing codec names Richard A. Holden III
2008-10-08 20:41 ` [PATCH 02/10] ixj: Remove dead code in preparation for consolidating duplicate code Richard A. Holden III
2008-10-08 20:41 ` [PATCH 03/10] ixj: Unify comments in preparation for pushing duplicate code into a function Richard A. Holden III
2008-10-08 20:41 ` [PATCH 04/10] ixj: Consolidate duplicate Ringer array initializers into common functions Richard A. Holden III
2008-10-08 20:41 ` [PATCH 05/10] ixj: Move duplicate code into well named zero_caller_id function Richard A. Holden III
2008-10-08 20:41 ` [PATCH 06/10] ixj: Caller ID Refactoring Richard A. Holden III
2008-10-08 20:41 ` [PATCH 07/10] ixj: Refactor DTMF tone setting Richard A. Holden III
2008-10-08 20:41 ` [PATCH 08/10] ixj: update quickly readable comments to match the data initializations Richard A. Holden III
2008-10-08 20:41 ` [PATCH 09/10] ixj: Remove unused macro Richard A. Holden III
2008-10-08 20:41 ` [PATCH 10/10] ixj: Remove dead code from ifdef IXJ_DYN_ALLOC Richard A. Holden III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081008211232.3a14b4ea@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=aciddeath@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®