From: Randy Dunlap <randy.dunlap@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch]fix wrong sysfs file attribute
Date: Thu, 9 Oct 2008 08:45:05 -0700 [thread overview]
Message-ID: <20081009084505.e5496a7c.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1223530282.30941.7.camel@sli10-desk.sh.intel.com>
On Thu, 09 Oct 2008 13:31:22 +0800 Shaohua Li wrote:
> This attribute just has write operation.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> ---
> drivers/base/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/drivers/base/memory.c
> ===================================================================
> --- linux.orig/drivers/base/memory.c 2008-10-09 11:41:40.000000000 +0800
> +++ linux/drivers/base/memory.c 2008-10-09 11:41:52.000000000 +0800
> @@ -325,7 +325,7 @@ memory_probe_store(struct class *class,
>
> return count;
> }
> -static CLASS_ATTR(probe, 0700, NULL, memory_probe_store);
> +static CLASS_ATTR(probe, 0200, NULL, memory_probe_store);
>
> static int memory_probe_init(void)
> {
#include <stat.h>
+static CLASS_ATTR(probe, S_IWUSR, NULL, memory_probe_store);
is almost readable.
---
~Randy
prev parent reply other threads:[~2008-10-09 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 5:31 Shaohua Li
2008-10-09 15:45 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009084505.e5496a7c.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®