From: Pavel Machek <pavel@suse.cz>
To: Matt Mackall <mpm@selenic.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: Why is arch/x86/kernel/acpi/sleep.c:temp_stack 10k?
Date: Thu, 9 Oct 2008 10:56:49 +0200 [thread overview]
Message-ID: <20081009085649.GC29957@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <1222819957.13453.15.camel@calx>
> We've got:
>
> #if defined(CONFIG_SMP) && defined(CONFIG_64BIT)
> static char temp_stack[10240];
> #endif
>
> and:
>
> #ifdef CONFIG_SMP
> stack_start.sp = temp_stack + 4096;
> #endif
>
> ..which suggests we use at most 4k of the stack?
I guess someone (probably me) was "playing it safe" -- not exactly
remembering if stack grows down or up. I guess it should be safe to
change it... will do that.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-10-09 8:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 0:12 Matt Mackall
2008-10-09 8:56 ` Pavel Machek [this message]
2008-10-09 16:56 ` [PATCH] x86: trim ACPI sleep stack buffer Matt Mackall
2008-10-09 17:19 ` Len Brown
2008-10-09 17:23 ` Moore, Robert
2008-10-09 17:41 ` Matt Mackall
2008-10-09 18:07 ` Pavel Machek
2008-10-09 18:35 ` Len Brown
2008-10-09 21:25 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009085649.GC29957@atrey.karlin.mff.cuni.cz \
--to=pavel@suse.cz \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®