From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] xen: use spin_lock_nest_lock when pinning a pagetable
Date: Thu, 9 Oct 2008 14:25:49 +0200 [thread overview]
Message-ID: <20081009122549.GA2952@elte.hu> (raw)
In-Reply-To: <48ED11A3.3090605@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> When pinning/unpinning a pagetable with split pte locks, we can end up
> holding multiple pte locks at once (we need to hold the locks while
> there's a pending batched hypercall affecting the pte page). Because
> all the pte locks are in the same lock class, lockdep thinks that
> we're potentially taking a lock recursively.
>
> This warning is spurious because we always take the pte locks while
> holding mm->page_table_lock. lockdep now has spin_lock_nest_lock to
> express this kind of dominant lock use, so use it here so that lockdep
> knows what's going on.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
> ---
> arch/x86/xen/mmu.c | 74 +++++++++++++++++++++++++++++++++-------------------
> arch/x86/xen/mmu.h | 3 --
> 2 files changed, 48 insertions(+), 29 deletions(-)
applied to tip/x86/xen, thanks Jeremy!
Ingo
prev parent reply other threads:[~2008-10-09 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 20:01 Jeremy Fitzhardinge
2008-10-09 12:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081009122549.GA2952@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®