mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Joe Perches <joe@perches.com>
Subject: Re: [patch] clean hex output of ftrace
Date: Thu, 9 Oct 2008 14:31:13 +0200	[thread overview]
Message-ID: <20081009123113.GB2952@elte.hu> (raw)
In-Reply-To: <1223513095.8195.113.camel@brick>


* Harvey Harrison <harvey.harrison@gmail.com> wrote:

> On Wed, 2008-10-08 at 17:16 -0700, Joe Perches wrote:
> > On Wed, 8 Oct 2008, Harvey Harrison wrote:
> > > From: Harvey Harrison <harvey.harrison@gmail.com>
> > > Subject: [PATCH] ftrace: Fix inversion of hex output and use common routines
> > 
> > You're quick...
> > 
> > >  	BUG_ON(len >= HEX_CHARS);
> > 
> > I think the BUG_ON is senseless.
> > 
> 
> Agreed, it probably meant to say BUG_ON(len * 2 > HEX_CHARS -1)
> 
> But as this is only called from within a helper macro, it could be
> changed to a build-time check instead of a runtime:
> 
> From: Harvey Harrison <harvey.harrison@gmail.com>
> Subject: [PATCH] trace: add build-time check to avoid overrunning hex buffer

applied to tip/tracing/core:

 bb86ba7: trace: add build-time check to avoid overrunning hex buffer
 32ce86f: ftrace: fix hex output mode of ftrace

thanks guys!

	Ingo

  reply	other threads:[~2008-10-09 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.30.0810081715520.2487-100000@perches.com>
2008-10-09  0:44 ` Harvey Harrison
2008-10-09 12:31   ` Ingo Molnar [this message]
2008-10-09 23:53     ` Harvey Harrison
2008-10-08 22:04 trem
2008-10-08 22:22 ` Joe Perches
2008-10-08 23:51   ` Harvey Harrison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081009123113.GB2952@elte.hu \
    --to=mingo@elte.hu \
    --cc=harvey.harrison@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®