From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758677AbYJIHQ3 (ORCPT ); Thu, 9 Oct 2008 03:16:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755943AbYJIHQA (ORCPT ); Thu, 9 Oct 2008 03:16:00 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:44433 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755635AbYJIHP7 (ORCPT ); Thu, 9 Oct 2008 03:15:59 -0400 From: KOSAKI Motohiro To: Andrew Morton Subject: Re: [mmotm 02/Oct] fix buid error of hid-core Cc: kosaki.motohiro@jp.fujitsu.com, LKML In-Reply-To: <20081009000208.d902be73.akpm@linux-foundation.org> References: <20081009154404.DED3.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20081009000208.d902be73.akpm@linux-foundation.org> Message-Id: <20081009160918.DED9.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Thu, 9 Oct 2008 16:15:55 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Ping! > > I'm in hiding until linux-next comes back. Oh, I see. sorry for that. > > > ------------------------- > > > CC [M] drivers/hid/usbhid/hid-core.o > > > drivers/hid/usbhid/hid-core.c: In function 'usbhid_submit_report': > > > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_driver_string' > > > drivers/hid/usbhid/hid-core.c:417: error: incompatible type for argument 1 of 'dev_name' > > > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_driver_string' > > > drivers/hid/usbhid/hid-core.c:436: error: incompatible type for argument 1 of 'dev_name' > > > drivers/hid/usbhid/hid-core.c: In function 'usbhid_init_reports': > > > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_driver_string' > > > drivers/hid/usbhid/hid-core.c:568: error: incompatible type for argument 1 of 'dev_name' > > > make[3]: *** [drivers/hid/usbhid/hid-core.o] Error 1 > > > make[2]: *** [drivers/hid/usbhid] Error 2 > > > make[1]: *** [drivers/hid] Error 2 > > > make: *** [drivers] Error 2 > > Attempting to remove a widely-used macro in a single patch within our > distributed development model was, frankly, short-sighted to the point > of stupidity. I've had enough of dealing with stuff like this. If > Stephen wants to take it on then fine. > > otoh given that others need to depend on this mess to get work done, I > guess I'm forced to continue to take out the garbage. Sigh. yup. I fully agree it ;)