From: Ingo Molnar <mingo@elte.hu>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly
Date: Fri, 10 Oct 2008 10:54:29 +0200 [thread overview]
Message-ID: <20081010085429.GB319@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0810092209460.21569@vinegar-pot.mit.edu>
* Anders Kaseorg <andersk@MIT.EDU> wrote:
> Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the
> 5-byte NOP ftrace_test_p6nop:
> jmp . + 5
> .byte 0x00, 0x00, 0x00
> This is not friendly to disassemblers because an odd number of 0x00s
> ends in the middle of an instruction boundary. This changes the 0x00s
> to 1-byte NOPs (0x90).
>
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>
applied to tip/tracing/ftrace, good spotting Anders!
Steve, any objections?
Ingo
next prev parent reply other threads:[~2008-10-10 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 2:19 Anders Kaseorg
2008-10-10 8:54 ` Ingo Molnar [this message]
2008-10-10 13:27 ` Steven Rostedt
2008-10-10 16:12 ` H. Peter Anvin
2008-10-10 16:56 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010085429.GB319@elte.hu \
--to=mingo@elte.hu \
--cc=andersk@MIT.EDU \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®