From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: Alan Cox <alan@redhat.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Better timeout recovery
Date: Fri, 10 Oct 2008 10:19:41 +0100 [thread overview]
Message-ID: <20081010101941.5822926e@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <87od1set2a.fsf@denkblock.local>
> I'd very much prefer comments to be formatted like this:
Would you... ;)
> > + /* Can become DEBUG later */
> > + if (count)
> > + ata_port_printk(ap, KERN_WARNING,
> > + "drained %d bytes to clear DRQ.\n", count);
> > +
> > +}
>
> Presumably, you didn't intentionally leave a blank line before the
> closing brace.
Yes I did, it looked cleaner.
> Sorry if you were aware of all that and just sent the patch as a first
> draft in order to get comments on the actual code.
At the moment the main concern is the code quality - but you are right
I've not run the result through the style checker and probably should do
so.
next prev parent reply other threads:[~2008-10-10 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 16:44 Alan Cox
2008-10-10 8:46 ` Elias Oltmanns
2008-10-10 9:19 ` Alan Cox [this message]
2008-10-10 13:24 ` Elias Oltmanns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010101941.5822926e@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=eo@nebensachen.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®