From: Ingo Molnar <mingo@elte.hu>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH] xen: do not reserve 2 pages of padding between hypervisor and fixmap.
Date: Fri, 10 Oct 2008 13:00:38 +0200 [thread overview]
Message-ID: <20081010110038.GB4699@elte.hu> (raw)
In-Reply-To: <1223634458-25820-1-git-send-email-Ian.Campbell@citrix.com>
* Ian Campbell <Ian.Campbell@citrix.com> wrote:
> When reserving space for the hypervisor the Xen paravirt backend adds
> an extra two pages (this was carried forward from the 2.6.18-xen tree
> which had them "for safety"). Depending on various CONFIG options this
> can cause the boot time fixmaps to span multiple PMDs which is not
> supported and triggers a WARN in early_ioremap_init().
>
> This was exposed by 2216d199b1430d1c0affb1498a9ebdbd9c0de439 which
> moved the dmi table parsing earlier.
> x86: fix CONFIG_X86_RESERVE_LOW_64K=y
>
> The bad_bios_dmi_table() quirk never triggered because we do DMI setup
> too late. Move it a bit earlier.
>
> There is no real reason to reserve these two extra pages and the
> fixmap already incorporates FIX_HOLE which serves the same
> purpose. None of the other callers of reserve_top_address do this.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Jeremy Fitzhardinge <jeremy@goop.org>
> Cc: Signed-off-by: Ingo Molnar <mingo@elte.hu>
applied to tip/x86/xen, thanks Ian!
Ingo
prev parent reply other threads:[~2008-10-10 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 10:27 Ian Campbell
2008-10-10 11:00 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010110038.GB4699@elte.hu \
--to=mingo@elte.hu \
--cc=Ian.Campbell@citrix.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®