From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: linux-ide@vger.kernel.org, torvalds@osdl.org, jens.axboe@oracle.com
Subject: Re: libata: set queue SSD flag for SSD devices
Date: Fri, 10 Oct 2008 20:25:15 +0100 [thread overview]
Message-ID: <20081010202515.446857cc@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <200810101904.m9AJ42Gq018897@hera.kernel.org>
> + ATA_ID_ROT_SPEED = 217,
> ATA_ID_PIO4 = (1 << 1),
>
> ATA_ID_SERNO_LEN = 20,
> @@ -691,6 +692,11 @@ static inline int ata_id_is_cfa(const u16 *id)
> return 0;
> }
>
> +static inline int ata_id_is_ssd(const u16 *id)
> +{
> + return id[ATA_ID_ROT_SPEED] == 0x01;
> +}
This patch is buggy.
Word 217 only has a defined meaning in late revision ATA standards so a
version check is needed. Please copy ATA patch copies to linux-ide.
Alan
next parent reply other threads:[~2008-10-10 19:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200810101904.m9AJ42Gq018897@hera.kernel.org>
2008-10-10 19:25 ` Alan Cox [this message]
2008-10-10 20:05 ` Jens Axboe
2008-10-11 0:55 ` Arjan van de Ven
2008-10-11 6:36 ` Jens Axboe
2008-10-11 7:33 ` James Bottomley
2008-10-11 14:06 ` Jens Axboe
2008-10-11 15:44 ` James Bottomley
2008-10-11 16:04 ` Arjan van de Ven
2008-10-11 16:38 ` James Bottomley
2008-10-11 16:49 ` Arjan van de Ven
2008-10-11 17:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081010202515.446857cc@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®