From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764406AbYJJVtj (ORCPT ); Fri, 10 Oct 2008 17:49:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760465AbYJJVta (ORCPT ); Fri, 10 Oct 2008 17:49:30 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:56071 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761410AbYJJVta (ORCPT ); Fri, 10 Oct 2008 17:49:30 -0400 Date: Fri, 10 Oct 2008 22:49:07 +0100 From: Alan Cox To: Greg KH Cc: "H. Peter Anvin" , Stefan Bader , stable@kernel.org, Thomas Gleixner , Ingo Molnar , Yinghai Lu , linux-kernel@vger.kernel.org Subject: Re: [stable] [PATCH] x86: Reserve FIRST_DEVICE_VECTOR in used_vectors bitmap Message-ID: <20081010224907.480a9aa2@lxorguk.ukuu.org.uk> In-Reply-To: <20081010211225.GA17695@kroah.com> References: <48EFB4B2.2020508@canonical.com> <20081010201805.GC32164@kroah.com> <48EFBCA4.6020008@zytor.com> <20081010204133.GB32357@kroah.com> <20081010215038.13be501e@lxorguk.ukuu.org.uk> <20081010211225.GA17695@kroah.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > And more importantly dev->irq == 0 or IRQ == 0 to anything but arch > > internal code means "no interrupt line". > > I thought we had changed that a while ago, as some arches had 0 as a > valid irq line. No .. Linus decreed (and I think sensibly myself that IRQ = 0 meant no IRQ assigned).. the argument being that in C you naturally write stuff like if (!dev->irq) I can dig up the reference URLS to the list mails if you want