From: Jeff Layton <jlayton@redhat.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Steven Noonan" <steven@uplinklabs.net>,
"Ingo Molnar" <mingo@elte.hu>,
"Steve French" <sfrench@us.ibm.com>,
linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>
Subject: Re: [PATCH] cifs: fix build on !CONFIG_KEYS
Date: Sun, 12 Oct 2008 07:30:37 -0400 [thread overview]
Message-ID: <20081012073037.20d399ee@tleilax.poochiereds.net> (raw)
In-Reply-To: <200810121330.49028.rjw@sisk.pl>
On Sun, 12 Oct 2008 13:30:48 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> On Sunday, 12 of October 2008, Steven Noonan wrote:
> > Hmm, which fix is correct though? Depending on KEYS in Kconfig, or
> > adding a nop for it?
>
> Well, according to git-blame the key_revoke() has been added to fs/cifs/sess.c
> only recently while key_put() was there before. For this reason I think it's
> correct to handle key_revoke() in analogy with key_put(), ie. add an empty
> definition for it if CONFIG_KEYS is unset.
>
> Thanks,
> Rafael
>
Agreed. It should be possible to build CIFS w/o KEYS support. Adding an empty
key_revoke looks like the right thing to do. Looks like Adrian Bunk sent a
patch for this a few hours ago:
Subject: [2.6 patch] add key_revoke() dummy for KEYS=n
--
Jeff Layton <jlayton@redhat.com>
prev parent reply other threads:[~2008-10-12 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 11:09 Ingo Molnar
2008-10-12 11:17 ` Rafael J. Wysocki
2008-10-12 11:14 ` Steven Noonan
2008-10-12 11:15 ` Steven Noonan
2008-10-12 11:30 ` Rafael J. Wysocki
2008-10-12 11:30 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012073037.20d399ee@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=sfrench@us.ibm.com \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®