From: Jeff Layton <jlayton@redhat.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Steve French <sfrench@us.ibm.com>,
linux-cifs-client@lists.samba.org
Subject: Re: [2.6 patch] add key_revoke() dummy for KEYS=n
Date: Sun, 12 Oct 2008 07:48:22 -0400 [thread overview]
Message-ID: <20081012074822.5caf32c5@tleilax.poochiereds.net> (raw)
In-Reply-To: <20081012041050.GB31153@cs181140183.pp.htv.fi>
On Sun, 12 Oct 2008 07:10:50 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> This patch fixes the following build error with CONFIG_KEYS=n, caused by
> commit dfd15c46a6c2cafb006183c0c14f07e59eee4ac0
> (cifs: explicitly revoke SPNEGO key after session setup):
>
> <-- snip -->
>
> ...
> CC [M] fs/cifs/sess.o
> fs/cifs/sess.c: In function 'CIFS_SessSetup':
> fs/cifs/sess.c:628: error: implicit declaration of function 'key_revoke'
> make[3]: *** [fs/cifs/sess.o] Error 1
>
> <-- snip -->
>
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> diff --git a/include/linux/key.h b/include/linux/key.h
> index c45c962..1b70e35 100644
> --- a/include/linux/key.h
> +++ b/include/linux/key.h
> @@ -299,6 +299,7 @@ extern void key_init(void);
> #define key_validate(k) 0
> #define key_serial(k) 0
> #define key_get(k) ({ NULL; })
> +#define key_revoke(k) do { } while(0)
> #define key_put(k) do { } while(0)
> #define key_ref_put(k) do { } while(0)
> #define make_key_ref(k, p) ({ NULL; })
>
Acked-by: Jeff Layton <jlayton@redhat.com>
prev parent reply other threads:[~2008-10-12 11:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-12 4:10 Adrian Bunk
2008-10-12 11:48 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012074822.5caf32c5@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®