From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org,
Ben Dooks <ben-linux@fluff.org>
Subject: Re: [patch 2/5] s3cmci: cpufreq support
Date: Sun, 12 Oct 2008 10:58:42 +0200 [thread overview]
Message-ID: <20081012105842.2c327627@mjolnir.drzeus.cx> (raw)
In-Reply-To: <20081010103314.435915526@fluff.org.uk>
On Fri, 10 Oct 2008 11:32:23 +0100
Ben Dooks <ben-linux@fluff.org> wrote:
> + host = container_of(nb, struct s3cmci_host, freq_transition);
> + newclk = clk_get_rate(host->clk);
> + mmc = host->mmc;
> +
> + if ((val == CPUFREQ_PRECHANGE && host->clk_rate > newclk) ||
> + (val == CPUFREQ_POSTCHANGE && host->clk_rate < newclk)) {
Isn't this backwards? The goal should be to avoid overclocking the
card, so if the old clock (which I assume is clk_rate) is slower than
the new clock (newclk), then we should adjust before the change happens,
temporarily underclocking the card.
(and vice versa for when the old clock is faster than the new clock)
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
next prev parent reply other threads:[~2008-10-12 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 10:32 [patch 0/5] MMC: S3C24XX updates for s3cmci driver Ben Dooks
2008-10-10 10:32 ` [patch 1/5] s3cmci: Make general protocol errors less noisy Ben Dooks
2008-10-10 10:32 ` [patch 2/5] s3cmci: cpufreq support Ben Dooks
2008-10-12 8:58 ` Pierre Ossman [this message]
2008-10-10 10:32 ` [patch 3/5] s3cmci: Support transfers which are not multiple of 32 bits Ben Dooks
2008-10-10 10:32 ` [patch 4/5] s3cmci: fix continual accesses to host->pio_ptr Ben Dooks
2008-10-10 10:32 ` [patch 5/5] s3cmci: Add Ben Dooks/Simtec Electronics to header & copyright Ben Dooks
2008-10-12 8:53 ` [patch 0/5] MMC: S3C24XX updates for s3cmci driver Pierre Ossman
2008-10-14 23:17 [patch 0/5] S3C24XX SD/MMC updates for 2.6.28-rc1 ben
2008-10-14 23:17 ` [patch 2/5] s3cmci: cpufreq support ben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081012105842.2c327627@mjolnir.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®