From: David Miller <davem@davemloft.net>
To: cooldavid@cooldavid.org
Cc: kamalesh@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
apw@shadowen.org, jgarzik@redhat.com, ron.mercer@qlogic.com,
scofeldm@cisco.com
Subject: Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()
Date: Mon, 13 Oct 2008 18:40:20 -0700 (PDT) [thread overview]
Message-ID: <20081013.184020.193699133.davem@davemloft.net> (raw)
In-Reply-To: <20081013192101.M74635@cooldavid.org>
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800
> But since <net/ip6_checksum.h> compensate the lack of
> `csum_ipv6_magic` function defined in <asm/checksum.h>
> of some architecture, should <net/ip6_checksum.h> be
> included in <net/checksum.h> as well?
No, the standard convention is that if you need to call this
ipv6 checksumming routine you include net/ip6_checksum.h
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800
> BTW, if there is a patch against jme driver which I maintain,
> and I just simply agree with it, should I silently noticed that
> and let someone like Jeff or David to review/apply it,
> or should I reply an ack of it?
You can ACK it and I usually apply patches like this directly.
next prev parent reply other threads:[~2008-10-14 1:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 12:14 Kamalesh Babulal
2008-10-13 19:28 ` Guo-Fu Tseng
2008-10-14 1:40 ` David Miller [this message]
2008-10-13 23:09 ` Ron Mercer
2008-10-14 1:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081013.184020.193699133.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=apw@shadowen.org \
--cc=cooldavid@cooldavid.org \
--cc=jgarzik@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®