From: David Miller <davem@davemloft.net>
To: sven.wegener@stealer.net
Cc: adobriyan@gmail.com, davej@redhat.com,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Subject: Re: sparc64 allmodconfig build failure...
Date: Tue, 14 Oct 2008 15:49:16 -0700 (PDT) [thread overview]
Message-ID: <20081014.154916.232117559.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.00.0810141434030.13897@titan.stealer.net>
From: Sven Wegener <sven.wegener@stealer.net>
Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)
> Yeah, with the default governor being any of supported governors, we
> either need some ugly #ifdef mess to only export the governor that
> is selected or just revert to the old code, which unconditionally
> exports all governors. Or something like the patch below. With the
> additional modules that I oversaw and that require the export, I'm
> fine with just reverting the commit, although I think that
> encapsulating the default governor decision in a built-in function
> is cleaner than having modules reference different symbols depending
> on configuration.
Personally I prefer the revert.
All of the alternative solutions shown far have been extremely
ugly.
next prev parent reply other threads:[~2008-10-14 22:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-14 6:02 David Miller
2008-10-14 8:30 ` Sven Wegener
2008-10-14 12:06 ` Alexey Dobriyan
2008-10-14 21:08 ` Sven Wegener
2008-10-14 22:49 ` David Miller [this message]
2008-10-15 22:05 ` Sven Wegener
2008-10-15 22:11 ` Dominik Brodowski
2008-10-15 22:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014.154916.232117559.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sven.wegener@stealer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®