From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: <dougthompson@xmission.com>
Cc: <linuxppc-dev@ozlabs.org>, <mniyer@us.ibm.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] edac/cell: Fix incorrect edac_mode in csrow causing oops
Date: Wed, 15 Oct 2008 15:40:19 +1100 [thread overview]
Message-ID: <20081015044057.584D6DDDFB@ozlabs.org> (raw)
The cell_edac driver is setting the edac_mode field of the
csrow's to an incorrect value, causing the sysfs show routine
for that field to go out of an array bound and Oopsing the kernel
when used.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/edac/cell_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-work.orig/drivers/edac/cell_edac.c 2008-10-15 15:35:21.000000000 +1100
+++ linux-work/drivers/edac/cell_edac.c 2008-10-15 15:35:29.000000000 +1100
@@ -142,7 +142,7 @@ static void __devinit cell_edac_init_csr
csrow->nr_pages = (r.end - r.start + 1) >> PAGE_SHIFT;
csrow->last_page = csrow->first_page + csrow->nr_pages - 1;
csrow->mtype = MEM_XDR;
- csrow->edac_mode = EDAC_FLAG_EC | EDAC_FLAG_SECDED;
+ csrow->edac_mode = EDAC_SECDED;
dev_dbg(mci->dev,
"Initialized on node %d, chanmask=0x%x,"
" first_page=0x%lx, nr_pages=0x%x\n",
reply other threads:[~2008-10-15 4:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081015044057.584D6DDDFB@ozlabs.org \
--to=benh@kernel.crashing.org \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mniyer@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®