From: Andrew Morton <akpm@linux-foundation.org>
To: Mark Jackson <mpfj@mimc.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for Dallas DS28CM00 Unique ID chip
Date: Thu, 16 Oct 2008 12:25:02 -0700 [thread overview]
Message-ID: <20081016122502.3ad6e958.akpm@linux-foundation.org> (raw)
In-Reply-To: <48EB5FA7.4080701@mimc.co.uk>
On Tue, 07 Oct 2008 14:09:59 +0100
Mark Jackson <mpfj@mimc.co.uk> wrote:
> This patch adds support for the (I2C based) DS28CM00 ID chip.
Please run scritps/checkpatch.pl across the diff and consider the
various things which it reports. Many of them are minor layout issues.
The lack of printk facility levels is a should-fix thing.
> printk("adding ds28cm00 driver !!\n");
Remove the " !!" :)
Please also cc i2c@lm-sensors.org on version 2.
Thanks.
prev parent reply other threads:[~2008-10-16 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 13:09 Mark Jackson
2008-10-16 19:25 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016122502.3ad6e958.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpfj@mimc.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome