From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Miller, Mike (OS Dev)" <Mike.Miller@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jens.axboe@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] cciss: fix regression in procfs display fw version, obsoletes previous patch 2 of 2
Date: Fri, 17 Oct 2008 03:17:36 +0400 [thread overview]
Message-ID: <20081016231736.GA7876@x200.localdomain> (raw)
In-Reply-To: <0F5B06BAB751E047AB5C87D1F77A77884C019B4CEF@GVW0547EXC.americas.hpqcorp.net>
On Thu, Oct 16, 2008 at 10:56:58PM +0000, Miller, Mike (OS Dev) wrote:
> > > > + return_code = sendcmd_withirq(CISS_INQUIRY, i, inq_buff,
> > > > > + sizeof(InquiryData_struct), 0, 0 ,0, TYPE_CMD);
> > > > > + if (return_code == IO_OK) {
> > > > > + hba[i]->firm_ver[0] = inq_buff->data_byte[32];
> > > > > + hba[i]->firm_ver[1] = inq_buff->data_byte[33];
> > > > > + hba[i]->firm_ver[2] = inq_buff->data_byte[34];
> > > > > + hba[i]->firm_ver[3] = inq_buff->data_byte[35];
> > > > > + } else { /* send command failed */
> > > > > + printk(KERN_WARNING "cciss: unable to
> > > > determine firmware"
> > > > > + " version of controller\n");
> > > > > + }
> > > > > +
> > > > > cciss_procinit(i);
> > > > >
> > > > > hba[i]->cciss_max_sectors = 2048;
> > >
> > > Sorry, in too much of a hurry. I'll fix (again).
> >
> > And inq_buff is leaked, if I'm not missing simething.
> >
> Sorry, Alexy, I can't see the leak. Is it in the failure case?
Where "inq_buff" is freed?
prev parent reply other threads:[~2008-10-16 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 21:50 Mike Miller
2008-10-16 21:56 ` Andrew Morton
2008-10-16 22:21 ` Miller, Mike (OS Dev)
2008-10-16 22:32 ` Alexey Dobriyan
2008-10-16 22:56 ` Miller, Mike (OS Dev)
2008-10-16 23:17 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081016231736.GA7876@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=Mike.Miller@hp.com \
--cc=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®