mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Jianjun Kong <jianjun@zeuux.org>
Cc: akpm@linux-foundation.org,
	Linux-Kernel-Mailing-List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] include/linux/mca-legacy.h: Fix the warning
Date: Fri, 17 Oct 2008 16:30:02 +0300	[thread overview]
Message-ID: <20081017133002.GA32584@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <20081017132044.GA22457@ubuntu>

On Fri, Oct 17, 2008 at 09:20:44PM +0800, Jianjun Kong wrote:
> Fix the warning of annotation.
> 
>   CC    drivers/mca/mca-legacy.o
>   In file included from drivers/mca/mca-legacy.c:31:
>   include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
>   please move your driver to the new sysfs api"
>   In file included from drivers/mca/mca-legacy.c:31:
>   include/linux/mca-legacy.h:12:2: warning: #warning "MCA legacy -
>   please move your driver to the new sysfs api"
> 
> Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
> ---
>  include/linux/mca-legacy.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/mca-legacy.h b/include/linux/mca-legacy.h
> index 7a3aea8..e349f2b 100644
> --- a/include/linux/mca-legacy.h
> +++ b/include/linux/mca-legacy.h
> @@ -9,7 +9,7 @@
>  
>  #include <linux/mca.h>
>  
> -#warning "MCA legacy - please move your driver to the new sysfs api"
> +/* warning "MCA legacy - please move your driver to the new sysfs api" */
>...

NAK

If you want to get rid of the warning fix the drivers still using the 
obsolete API.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


      reply	other threads:[~2008-10-17 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-17 13:20 Jianjun Kong
2008-10-17 13:30 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081017133002.GA32584@cs181140183.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=jianjun@zeuux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®