From: Alexey Dobriyan <adobriyan@gmail.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] init: Properly placing noinline keyword.
Date: Fri, 17 Oct 2008 18:13:54 +0400 [thread overview]
Message-ID: <20081017141354.GA9242@x200.localdomain> (raw)
In-Reply-To: <b9df5fa10810170605t50e366e9nf62f8a18df37fc3c@mail.gmail.com>
On Fri, Oct 17, 2008 at 07:05:32PM +0600, Rakib Mullick wrote:
> Here, noinline keyword should be placed between storage class and type.
Why?
> --- linux-2.6-stable.orig/init/main.c
> +++ linux-2.6-stable/init/main.c
> @@ -457,7 +457,7 @@ static void __init setup_command_line(ch
> * gcc-3.4 accidentally inlines this function, so use noinline.
> */
>
> -static void noinline __init_refok rest_init(void)
> +static noinline void __init_refok rest_init(void)
> __releases(kernel_lock)
> {
> int pid;
> @@ -792,7 +792,7 @@ static void run_init_process(char *init_
> /* This is a non __init function. Force it to be noinline otherwise gcc
> * makes it inline to init() and it becomes part of init.text section
> */
> -static int noinline init_post(void)
> +static noinline int init_post(void)
next prev parent reply other threads:[~2008-10-17 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 13:05 Rakib Mullick
2008-10-17 14:13 ` Alexey Dobriyan [this message]
2008-10-17 14:17 ` Rakib Mullick
2008-10-17 14:26 ` Américo Wang
2008-10-17 15:10 ` Rakib Mullick
2008-10-17 17:31 ` Américo Wang
2008-10-20 22:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017141354.GA9242@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®