From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752008AbYJVE4j (ORCPT ); Wed, 22 Oct 2008 00:56:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750959AbYJVE4a (ORCPT ); Wed, 22 Oct 2008 00:56:30 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:34480 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750805AbYJVE4a (ORCPT ); Wed, 22 Oct 2008 00:56:30 -0400 Date: Tue, 21 Oct 2008 21:56:07 -0700 (PDT) Message-Id: <20081021.215607.193696998.davem@davemloft.net> To: fweisbec@gmail.com Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH] sparc: correct section of apc_no_idle From: David Miller In-Reply-To: <48FA0AB6.3060505@gmail.com> References: <48FA0AB6.3060505@gmail.com> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frederic Weisbecker Date: Sat, 18 Oct 2008 18:11:34 +0200 [ Please post sparc patches to sparclinux@vger.kernel.org in the future, CC:'d ] > The latest mainline gives this section mismatch on sparc: > > The function __devinit apc_probe() references > a variable __initdata apc_no_idle. > If apc_no_idle is only used by apc_probe then > annotate apc_no_idle with a matching annotation. > > Since the commit 7e7e2f035663c5ceb029bfb9d91e75099b0a5625, > apc_probe() is on __devinit so we have to correct apc_no_idle > which is referenced by this function. > > Signed-off-by: Frederic Weisbecker Applied, thanks. > diff --git a/arch/sparc/kernel/apc.c b/arch/sparc/kernel/apc.c > index 4dd1ba7..9c11582 100644 > --- a/arch/sparc/kernel/apc.c > +++ b/arch/sparc/kernel/apc.c > @@ -31,7 +31,7 @@ > #define APC_DEVNAME "apc" > > static u8 __iomem *regs; > -static int apc_no_idle __initdata = 0; > +static int apc_no_idle __devinitdata = 0; > > #define apc_readb(offs) (sbus_readb(regs+offs)) > #define apc_writeb(val, offs) (sbus_writeb(val, regs+offs))