From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [git pull] irq fixes
Date: Tue, 21 Oct 2008 16:14:28 +0200 [thread overview]
Message-ID: <20081021141427.GA20066@elte.hu> (raw)
Linus,
Please pull the latest irq-fixes-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq-fixes-for-linus
Thanks,
Ingo
------------------>
Chris Friesen (1):
genirq: fix set_irq_type() when recording trigger type
Dean Nelson (1):
genirq: NULL struct irq_desc's member 'name' in dynamic_irq_cleanup()
Ingo Molnar (1):
genirq: fix off by one and coding style
arch/x86/kernel/irq.c | 4 ++--
include/linux/irqnr.h | 6 +++---
kernel/irq/chip.c | 3 ++-
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index ccf6c50..d1d4dc5 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -36,7 +36,7 @@ void ack_bad_irq(unsigned int irq)
}
#ifdef CONFIG_X86_32
-# define irq_stats(x) (&per_cpu(irq_stat,x))
+# define irq_stats(x) (&per_cpu(irq_stat, x))
#else
# define irq_stats(x) cpu_pda(x)
#endif
@@ -113,7 +113,7 @@ int show_interrupts(struct seq_file *p, void *v)
if (i == 0) {
seq_printf(p, " ");
for_each_online_cpu(j)
- seq_printf(p, "CPU%-8d",j);
+ seq_printf(p, "CPU%-8d", j);
seq_putc(p, '\n');
}
diff --git a/include/linux/irqnr.h b/include/linux/irqnr.h
index 3171ddc..452c280 100644
--- a/include/linux/irqnr.h
+++ b/include/linux/irqnr.h
@@ -13,9 +13,9 @@ extern int nr_irqs;
# define for_each_irq_desc(irq, desc) \
for (irq = 0, desc = irq_desc; irq < nr_irqs; irq++, desc++)
-# define for_each_irq_desc_reverse(irq, desc) \
- for (irq = nr_irqs -1, desc = irq_desc + (nr_irqs -1 ); \
- irq > 0; irq--, desc--)
+# define for_each_irq_desc_reverse(irq, desc) \
+ for (irq = nr_irqs - 1, desc = irq_desc + (nr_irqs - 1); \
+ irq >= 0; irq--, desc--)
#endif
#define for_each_irq_nr(irq) \
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 4895fde..10b5092 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -76,6 +76,7 @@ void dynamic_irq_cleanup(unsigned int irq)
desc->chip_data = NULL;
desc->handle_irq = handle_bad_irq;
desc->chip = &no_irq_chip;
+ desc->name = NULL;
spin_unlock_irqrestore(&desc->lock, flags);
}
@@ -127,7 +128,7 @@ int set_irq_type(unsigned int irq, unsigned int type)
return 0;
spin_lock_irqsave(&desc->lock, flags);
- ret = __irq_set_trigger(desc, irq, flags);
+ ret = __irq_set_trigger(desc, irq, type);
spin_unlock_irqrestore(&desc->lock, flags);
return ret;
}
next reply other threads:[~2008-10-21 14:14 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 14:14 Ingo Molnar [this message]
2008-11-29 19:41 Ingo Molnar
2009-01-06 16:13 Ingo Molnar
2009-01-30 23:10 Ingo Molnar
2009-04-09 15:39 [GIT PULL] " Ingo Molnar
2009-04-26 17:13 Ingo Molnar
2009-06-20 17:26 [GIT PULL] IRQ fixes Ingo Molnar
2010-03-26 15:09 [GIT PULL] irq fixes Ingo Molnar
2011-02-06 11:58 Ingo Molnar
2011-02-22 16:19 Ingo Molnar
2011-03-18 13:49 Ingo Molnar
2011-03-25 13:03 Ingo Molnar
2011-06-07 18:48 Ingo Molnar
2011-09-30 18:16 Ingo Molnar
2011-09-30 18:35 ` Josh Boyer
2011-09-30 19:43 ` Thomas Gleixner
2012-02-27 10:26 Ingo Molnar
2015-02-20 13:35 [GIT PULL] IRQ fixes Ingo Molnar
2015-07-18 2:36 [GIT PULL] irq fixes Ingo Molnar
2016-01-31 9:01 [GIT PULL] IRQ fixes Ingo Molnar
2016-04-23 11:15 [GIT PULL] irq fixes Ingo Molnar
2016-07-08 13:37 Ingo Molnar
2016-10-18 10:18 Ingo Molnar
2016-10-22 10:40 [GIT PULL] IRQ fixes Ingo Molnar
2017-02-11 18:06 Ingo Molnar
2017-07-21 10:07 [GIT PULL] irq fixes Ingo Molnar
2017-09-12 15:30 [GIT PULL] IRQ fixes Ingo Molnar
2017-09-24 11:21 Ingo Molnar
2017-10-14 15:57 Ingo Molnar
2017-12-06 22:09 Ingo Molnar
2018-11-03 22:59 Ingo Molnar
2018-11-04 1:13 ` Linus Torvalds
2019-02-10 9:08 Ingo Molnar
2019-02-10 18:30 ` pr-tracker-bot
2019-04-12 11:52 Ingo Molnar
2019-04-13 4:05 ` pr-tracker-bot
2019-06-29 8:50 Ingo Molnar
2019-06-29 11:45 ` pr-tracker-bot
2020-08-03 10:54 Ingo Molnar
2020-08-03 22:10 ` pr-tracker-bot
2021-07-11 13:40 Ingo Molnar
2021-07-11 18:22 ` pr-tracker-bot
2022-08-21 21:10 Ingo Molnar
2022-08-21 23:13 ` pr-tracker-bot
2024-06-08 7:52 Ingo Molnar
2024-06-08 16:50 ` pr-tracker-bot
2025-02-22 13:48 Ingo Molnar
2025-02-22 19:23 ` pr-tracker-bot
2025-04-10 21:38 Ingo Molnar
2025-04-10 22:52 ` pr-tracker-bot
2025-04-18 20:26 Ingo Molnar
2025-04-18 21:15 ` pr-tracker-bot
2025-05-04 7:08 Ingo Molnar
2025-05-04 15:23 ` pr-tracker-bot
2025-05-17 13:37 Ingo Molnar
2025-05-17 16:27 ` pr-tracker-bot
2025-12-12 9:33 Ingo Molnar
2025-12-13 18:12 ` pr-tracker-bot
2026-01-11 10:22 Ingo Molnar
2026-01-12 19:38 ` pr-tracker-bot
2026-01-24 9:20 Ingo Molnar
2026-01-24 18:00 ` pr-tracker-bot
2026-02-01 8:40 Ingo Molnar
2026-02-01 19:46 ` pr-tracker-bot
2026-03-01 8:48 Ingo Molnar
2026-03-01 21:37 ` pr-tracker-bot
2026-03-15 2:59 Ingo Molnar
2026-03-15 18:47 ` pr-tracker-bot
2026-03-29 5:10 Ingo Molnar
2026-03-29 17:29 ` pr-tracker-bot
2026-05-17 6:20 Ingo Molnar
2026-05-17 19:28 ` pr-tracker-bot
2026-05-24 6:52 Ingo Molnar
2026-05-24 20:12 ` pr-tracker-bot
2026-06-23 16:55 Ingo Molnar
2026-06-24 0:20 ` pr-tracker-bot
2026-07-05 7:26 Ingo Molnar
2026-07-05 15:46 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021141427.GA20066@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox