mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: remove superfluous dmi_ignore_irq0_timer_override quirks
Date: Wed, 22 Oct 2008 12:02:54 +0200	[thread overview]
Message-ID: <20081022100253.GB29744@elte.hu> (raw)
In-Reply-To: <20081016105706.GC29183@alberich.amd.com>


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> The problem should be solved with commits:
> 
> x86: SB600: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC
> 
> IMHO it does not make sense to check within a dmi-quirk
> whether an early-quirk was applied. Boot sequence is as follows:
> 
> acpi_boot_table_init()   (it applies dmi-quirks)
> ...
> early_quirks()           (detect bogus IRQ0 override)
> ...
> acpi_boot_init()         (setup IO APIC)
> 
> Thus with current code we will always get following warnings for
> Laptops that have this dmi_ignore_irq0_timer_override dmi quirk:
> 
>   WARNING: at arch/x86/kernel/acpi/boot.c:1410
>   dmi_ignore_irq0_timer_override+0x30/0x60()
>   ati_ixp4x0 quirk not complete.
> 
> ... just because the early-quirk (ati_ixp4x0) was not yet executed.

could we move the DMI check to after the early quicks stage? It would be 
nice to have this double check, for at least one kernel cycle.

	Ingo

  reply	other threads:[~2008-10-22 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 10:57 Andreas Herrmann
2008-10-22 10:02 ` Ingo Molnar [this message]
2008-10-22 10:09   ` Andreas Herrmann
2008-10-22 11:28     ` [PATCH] x86: call dmi-quirks for HP Laptops after early-quirks are executed Andreas Herrmann
2008-10-22 12:55       ` Ingo Molnar
2008-10-22 10:03 ` [PATCH] x86: remove superfluous dmi_ignore_irq0_timer_override quirks Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022100253.GB29744@elte.hu \
    --to=mingo@elte.hu \
    --cc=andreas.herrmann3@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®