From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756808AbYJVSIw (ORCPT ); Wed, 22 Oct 2008 14:08:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752008AbYJVSIn (ORCPT ); Wed, 22 Oct 2008 14:08:43 -0400 Received: from gcore.biz ([212.69.172.75]:39829 "HELO gcore.biz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751712AbYJVSIn (ORCPT ); Wed, 22 Oct 2008 14:08:43 -0400 X-Greylist: delayed 400 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 Oct 2008 14:08:42 EDT Date: Wed, 22 Oct 2008 20:03:01 +0200 From: Wolfgang Kroworsch To: Alan Cox Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] vt: incomplete initialization of vc_tab_stop Message-ID: <20081022180301.GA10627@kroworsch.de> References: <20081018114929.GA25554@kroworsch.de> <20081022112705.10f9aa4a@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081022112705.10f9aa4a@lxorguk.ukuu.org.uk> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 22, 2008 at 11:27:05AM +0100 Alan Cox wrote: > On Sat, 18 Oct 2008 13:49:31 +0200 Wolfgang Kroworsch wrote: > > > Problem 1 (see patch below): > > vc_tab_stop is declared as an array of 8 unsigned ints in struct > > vc_data in include/linux/console_struct.h . > > In drivers/char/vt.c only 5 of these 8 unsigned ints get initialized > > leading to unintended tabulator placement on displays with more than > > 160 columns text. > > Seems sensible enough - but need a Signed-off-by line to apply. Thx, Wolfgang Signed-off-by: Wolfgang Kroworsch --- drivers/char/vt.c | 10 ++++++++-- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/char/vt.c b/drivers/char/vt.c index d8f83e2..a5af607 100644 --- a/drivers/char/vt.c +++ b/drivers/char/vt.c @@ -1644,7 +1644,10 @@ static void reset_terminal(struct vc_data *vc, int do_clear) vc->vc_tab_stop[1] = vc->vc_tab_stop[2] = vc->vc_tab_stop[3] = - vc->vc_tab_stop[4] = 0x01010101; + vc->vc_tab_stop[4] = + vc->vc_tab_stop[5] = + vc->vc_tab_stop[6] = + vc->vc_tab_stop[7] = 0x01010101; vc->vc_bell_pitch = DEFAULT_BELL_PITCH; vc->vc_bell_duration = DEFAULT_BELL_DURATION; @@ -1935,7 +1938,10 @@ static void do_con_trol(struct tty_struct *tty, struct vc_data *vc, int c) vc->vc_tab_stop[1] = vc->vc_tab_stop[2] = vc->vc_tab_stop[3] = - vc->vc_tab_stop[4] = 0; + vc->vc_tab_stop[4] = + vc->vc_tab_stop[5] = + vc->vc_tab_stop[6] = + vc->vc_tab_stop[7] = 0; } return; case 'm':