From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754715AbYJWLFz (ORCPT ); Thu, 23 Oct 2008 07:05:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752508AbYJWLFp (ORCPT ); Thu, 23 Oct 2008 07:05:45 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:60013 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbYJWLFp (ORCPT ); Thu, 23 Oct 2008 07:05:45 -0400 Date: Thu, 23 Oct 2008 13:05:24 +0200 From: Ingo Molnar To: Mike Travis Cc: Rusty Russell , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 27/35] cpumask: accessors to manipulate possible/present/online/active maps From: Rusty Russell Message-ID: <20081023110524.GB25132@elte.hu> References: <20081023020826.051012000@polaris-admin.engr.sgi.com> <20081023020831.698704000@polaris-admin.engr.sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081023020831.698704000@polaris-admin.engr.sgi.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mike Travis wrote: > +void set_cpu_possible(unsigned int cpu, bool possible) > +{ > + if (possible) > + cpumask_set_cpu(cpu, &cpu_possible_map); > + else > + cpumask_clear_cpu(cpu, &cpu_possible_map); > +} > +void set_cpu_present(unsigned int cpu, bool present) > +{ i added the missing newlines between all the new function definitions. Ingo